From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16000 invoked by alias); 27 Apr 2009 07:07:58 -0000 Received: (qmail 15990 invoked by uid 22791); 27 Apr 2009 07:07:57 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from hq2.tensilica.com (HELO maia.hq.tensilica.com) (65.205.227.30) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Apr 2009 07:07:52 +0000 Received: from [172.16.150.11] (nose.hq.tensilica.com [172.16.150.11]) (authenticated bits=0) by maia.hq.tensilica.com (8.13.1/8.13.1) with ESMTP id n3R77JrR001956; Mon, 27 Apr 2009 00:07:19 -0700 Message-ID: <49F559A6.5060705@tensilica.com> Date: Mon, 27 Apr 2009 07:07:00 -0000 From: Ross Morley User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040805 Netscape/7.2 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org, maxim@tensilica.com Subject: Re: [PATCH] Program Breakpoints References: <49E93221.7010502@tensilica.com> <49EE7130.10505@tensilica.com> <83hc0hgz5p.fsf@gnu.org> In-Reply-To: <83hc0hgz5p.fsf@gnu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00728.txt.bz2 Thanks for approving the doc. I will add the cross reference as you suggest after the code is reviewed in case other changes are needed. Still waiting for code review. Ross Eli Zaretskii wrote: >>Date: Tue, 21 Apr 2009 18:21:52 -0700 >>From: Ross Morley >>CC: Maxim Grigoriev >> >>I've also incorporated Eli's feedback on the doc and NEWS (maybe I went >>a bit verbose on the NEWS, but you can tell me what to cut). I kept using >>the term "target" in the remote protocol section because it's common there. >> >>New patch attached, replaces previous. >> >> > >Thanks. I have only one comment: > > > >>+@item program-breakpoint >>+A program breakpoint (trap instruction unknown to @value{GDBN}) was reached. >> >> > >This place is far from where you explained what a program breakpoint >is. So I suggest a cross-reference here to the node where program >breakpoints are described. > >Sorry I didn't notice this in the original review. > >Other than that, the patch for the manual is approved. > > > >>Index: gdb/NEWS >> >> > >This is fine. > > >