From: Eli Zaretskii <eliz@gnu.org>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch][python] Implement Python lazy strings (PR 10705)
Date: Mon, 11 Jan 2010 19:10:00 -0000 [thread overview]
Message-ID: <83hbqs8nl2.fsf@gnu.org> (raw)
In-Reply-To: <4B4B464F.1060405@redhat.com>
> Date: Mon, 11 Jan 2010 15:39:59 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: gdb-patches@sourceware.org
>
> Thanks for the review. I've updated the patch in accordance with your
> requests. How does this look?
It's good to go, but please fix one small error in usage of Texinfo:
> +the string type. For further information on encoding in @value{GDBN}
> +please see: @pxref{Character Sets}.
^^^^^^^^^^^^^^^^^^^^^^^^^^^
You want "see @ref{Character Sets}." here. @pxref is for
cross-references that you put in parentheses.
> +@pxref{Types In Python}. This attribute is not writable.
Two spaces, please.
Thanks.
next prev parent reply other threads:[~2010-01-11 19:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 14:52 Phil Muldoon
2010-01-08 16:25 ` Eli Zaretskii
2010-01-11 15:40 ` Phil Muldoon
2010-01-11 19:10 ` Eli Zaretskii [this message]
2010-01-11 21:08 ` Tom Tromey
2010-01-11 21:30 ` Phil Muldoon
2010-01-11 21:40 ` Phil Muldoon
2010-01-12 17:02 ` Tom Tromey
2010-01-13 14:49 ` Phil Muldoon
2010-01-13 18:13 ` Tom Tromey
2010-01-13 20:23 ` Phil Muldoon
2010-01-13 20:33 ` Tom Tromey
2010-01-14 21:24 ` Phil Muldoon
2010-01-13 18:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83hbqs8nl2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox