From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69445-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30672 invoked by alias); 11 Jan 2010 19:10:35 -0000
Received: (qmail 30657 invoked by uid 22791); 11 Jan 2010 19:10:34 -0000
X-SWARE-Spam-Status: No, hits=0.4 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jan 2010 19:10:29 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0KW300800JUYQ700@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Mon, 11 Jan 2010 21:09:45 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.127.222.44]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KW3008YTJW46Q20@a-mtaout23.012.net.il>; Mon, 11 Jan 2010 21:09:41 +0200 (IST)
Date: Mon, 11 Jan 2010 19:10:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][python] Implement Python lazy strings (PR 10705)
In-reply-to: <4B4B464F.1060405@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83hbqs8nl2.fsf@gnu.org>
References: <4B4746A7.90309@redhat.com> <83vdfca7im.fsf@gnu.org> <4B4B464F.1060405@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-01/txt/msg00269.txt.bz2

> Date: Mon, 11 Jan 2010 15:39:59 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: gdb-patches@sourceware.org
> 
> Thanks for the review.  I've updated the patch in accordance with your
> requests.  How does this look?

It's good to go, but please fix one small error in usage of Texinfo:

> +the string type.  For further information on encoding in @value{GDBN}
> +please see: @pxref{Character Sets}.
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
You want "see @ref{Character Sets}." here.  @pxref is for
cross-references that you put in parentheses.

> +@pxref{Types In Python}. This attribute is not writable.

Two spaces, please.

Thanks.