Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch][python] Implement Python lazy strings (PR 10705)
Date: Tue, 12 Jan 2010 17:02:00 -0000	[thread overview]
Message-ID: <m3wrznmf2o.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B4B9867.5080805@redhat.com> (Phil Muldoon's message of "Mon, 11 	Jan 2010 21:30:15 +0000")

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> +  output = convert_value_from_python (string);

Tom> Why do we need to do this?
Tom> Can't we just get the address directly?

Phil> As a lazy string is a pointer, the code needs to actually find the
Phil> type associated with the characters in the string. So later in the
Phil> code:
Phil>  if (TYPE_CODE (value_type (output)) == TYPE_CODE_PTR)
Phil>     output = value_ind (output);

Yes, but calling convert_value_from_python means calling a method on the
Lazy_string object to get a Value, then unpacking that -- but the actual
pointer value is directly available in the object.

Tom


  parent reply	other threads:[~2010-01-12 17:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08 14:52 Phil Muldoon
2010-01-08 16:25 ` Eli Zaretskii
2010-01-11 15:40   ` Phil Muldoon
2010-01-11 19:10     ` Eli Zaretskii
2010-01-11 21:08 ` Tom Tromey
2010-01-11 21:30   ` Phil Muldoon
2010-01-11 21:40     ` Phil Muldoon
2010-01-12 17:02     ` Tom Tromey [this message]
2010-01-13 14:49   ` Phil Muldoon
2010-01-13 18:13     ` Tom Tromey
2010-01-13 20:23       ` Phil Muldoon
2010-01-13 20:33         ` Tom Tromey
2010-01-14 21:24           ` Phil Muldoon
2010-01-13 18:24     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wrznmf2o.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox