From: Eli Zaretskii <eliz@gnu.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc v2][4/6] Readlink as file I/O target operation
Date: Fri, 13 Jan 2012 18:29:00 -0000 [thread overview]
Message-ID: <83hazzjw3x.fsf@gnu.org> (raw)
In-Reply-To: <201201131815.q0DIFCKZ001538@d06av02.portsmouth.uk.ibm.com>
> Date: Fri, 13 Jan 2012 19:15:12 +0100 (CET)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
>
> --- gdb-head.orig/gdb/doc/gdb.texinfo 2012-01-13 18:44:34.000000000 +0100
> +++ gdb-head/gdb/doc/gdb.texinfo 2012-01-13 18:45:57.000000000 +0100
> @@ -17450,6 +17450,10 @@ are:
> @tab @code{vFile:unlink}
> @tab @code{remote delete}
>
> +@item @code{hostio-readlink-packet}
> +@tab @code{vFile:readlink}
> +@tab Host I/O
> +
> @item @code{noack-packet}
> @tab @code{QStartNoAckMode}
> @tab Packet acknowledgment
> @@ -36193,6 +36197,16 @@ error occurred.
> Delete the file at @var{pathname} on the target. Return 0,
> or -1 if an error occurs. @var{pathname} is a string.
>
> +@item vFile:readlink: @var{pathname}
> +Read value of symbolic link @var{pathname} on the target. Return
> +the number of bytes read, or -1 if an error occurs.
> +
> +The data read should be returned as a binary attachment on success.
> +If zero bytes were read, the response should include an empty binary
> +attachment (i.e.@: a trailing semicolon). The return value is the
> +number of target bytes read; the binary attachment may be longer if
> +some characters were escaped.
> +
This part is okay, but please don't use "pathname" when you really
mean "file name". GNU Coding Standards frown on using "path" or its
derivatives for anything but PATH-style directory lists.
Thanks.
next prev parent reply other threads:[~2012-01-13 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 18:16 Ulrich Weigand
2012-01-13 18:29 ` Eli Zaretskii [this message]
2012-01-16 13:29 ` Ulrich Weigand
2012-01-16 14:48 ` Eli Zaretskii
2012-01-16 15:03 ` Ulrich Weigand
2012-01-16 17:18 ` Eli Zaretskii
2012-01-16 15:37 ` Pedro Alves
2012-01-16 17:26 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83hazzjw3x.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox