From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87099-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7641 invoked by alias); 13 Jan 2012 18:28:53 -0000
Received: (qmail 7543 invoked by uid 22791); 13 Jan 2012 18:28:52 -0000
X-SWARE-Spam-Status: No, hits=0.1 required=5.0	tests=AWL,BAYES_50,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Jan 2012 18:28:38 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LXR002001JF9000@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 13 Jan 2012 20:27:56 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.136.230]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LXR001EW1YJP590@a-mtaout20.012.net.il>; Fri, 13 Jan 2012 20:27:56 +0200 (IST)
Date: Fri, 13 Jan 2012 18:29:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [rfc v2][4/6] Readlink as file I/O target operation
In-reply-to: <201201131815.q0DIFCKZ001538@d06av02.portsmouth.uk.ibm.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83hazzjw3x.fsf@gnu.org>
References: <201201131815.q0DIFCKZ001538@d06av02.portsmouth.uk.ibm.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00496.txt.bz2

> Date: Fri, 13 Jan 2012 19:15:12 +0100 (CET)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> 
> --- gdb-head.orig/gdb/doc/gdb.texinfo	2012-01-13 18:44:34.000000000 +0100
> +++ gdb-head/gdb/doc/gdb.texinfo	2012-01-13 18:45:57.000000000 +0100
> @@ -17450,6 +17450,10 @@ are:
>  @tab @code{vFile:unlink}
>  @tab @code{remote delete}
>  
> +@item @code{hostio-readlink-packet}
> +@tab @code{vFile:readlink}
> +@tab Host I/O
> +
>  @item @code{noack-packet}
>  @tab @code{QStartNoAckMode}
>  @tab Packet acknowledgment
> @@ -36193,6 +36197,16 @@ error occurred.
>  Delete the file at @var{pathname} on the target.  Return 0,
>  or -1 if an error occurs.  @var{pathname} is a string.
>  
> +@item vFile:readlink: @var{pathname}
> +Read value of symbolic link @var{pathname} on the target.  Return
> +the number of bytes read, or -1 if an error occurs.
> +
> +The data read should be returned as a binary attachment on success.
> +If zero bytes were read, the response should include an empty binary
> +attachment (i.e.@: a trailing semicolon).  The return value is the
> +number of target bytes read; the binary attachment may be longer if
> +some characters were escaped.
> +

This part is okay, but please don't use "pathname" when you really
mean "file name".  GNU Coding Standards frown on using "path" or its
derivatives for anything but PATH-style directory lists.

Thanks.