Re: [rfc v2][4/6] Readlink as file I/O target operation

["Ulrich Weigand" <uweigand@de.ibm.com>]

Eli Zaretskii wrote:
> > Date: Mon, 16 Jan 2012 13:32:23 +0100 (CET)
> > From: "Ulrich Weigand" <uweigand@de.ibm.com>
> > Cc: gdb-patches@sourceware.org
> > I'll be happy to use "filename" instead, but the currently existing
> > packets (open, unlink) also use "pathname" today.  Should those be
> > changed to "filename" too?
> 
> In general, yes.  But I cannot in good faith ask you to do that as
> part of this patch.  So let's make a first small step in this
> 1000-mile journey by using "filename" in just this part.  I'll add to
> my todo to fix the rest, if no one beats me to it.

Fair enough.  Appended below is the updated doc part of the patch,
just making the pathname -> filename change for readlink.

Thanks,
Ulrich


Index: gdb-head/gdb/doc/gdb.texinfo
===================================================================
--- gdb-head.orig/gdb/doc/gdb.texinfo	2012-01-13 18:44:34.000000000 +0100
+++ gdb-head/gdb/doc/gdb.texinfo	2012-01-16 15:03:17.000000000 +0100
@@ -17450,6 +17450,10 @@ are:
 @tab @code{vFile:unlink}
 @tab @code{remote delete}
 
+@item @code{hostio-readlink-packet}
+@tab @code{vFile:readlink}
+@tab Host I/O
+
 @item @code{noack-packet}
 @tab @code{QStartNoAckMode}
 @tab Packet acknowledgment
@@ -36193,6 +36197,16 @@ error occurred.
 Delete the file at @var{pathname} on the target.  Return 0,
 or -1 if an error occurs.  @var{pathname} is a string.
 
+@item vFile:readlink: @var{filename}
+Read value of symbolic link @var{filename} on the target.  Return
+the number of bytes read, or -1 if an error occurs.
+
+The data read should be returned as a binary attachment on success.
+If zero bytes were read, the response should include an empty binary
+attachment (i.e.@: a trailing semicolon).  The return value is the
+number of target bytes read; the binary attachment may be longer if
+some characters were escaped.
+
 @end table
 
 @node Interrupts

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com