From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2274 invoked by alias); 16 Jan 2012 14:48:28 -0000 Received: (qmail 2260 invoked by uid 22791); 16 Jan 2012 14:48:25 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jan 2012 14:48:12 +0000 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Jan 2012 14:48:10 -0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com ([9.149.39.225]) by e06smtp16.uk.ibm.com ([192.168.101.146]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 16 Jan 2012 14:48:08 -0000 Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0GEm70G2531558 for ; Mon, 16 Jan 2012 14:48:07 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0GElmcj003162 for ; Mon, 16 Jan 2012 07:48:06 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q0GE7htU029197; Mon, 16 Jan 2012 07:07:43 -0700 Message-Id: <201201161407.q0GE7htU029197@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 16 Jan 2012 15:07:43 +0100 Subject: Re: [rfc v2][4/6] Readlink as file I/O target operation To: eliz@gnu.org Date: Mon, 16 Jan 2012 15:03:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: from "Eli Zaretskii" at Jan 16, 2012 08:29:33 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit x-cbid: 12011614-3548-0000-0000-000000B69B32 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00543.txt.bz2 Eli Zaretskii wrote: > > Date: Mon, 16 Jan 2012 13:32:23 +0100 (CET) > > From: "Ulrich Weigand" > > Cc: gdb-patches@sourceware.org > > I'll be happy to use "filename" instead, but the currently existing > > packets (open, unlink) also use "pathname" today. Should those be > > changed to "filename" too? > > In general, yes. But I cannot in good faith ask you to do that as > part of this patch. So let's make a first small step in this > 1000-mile journey by using "filename" in just this part. I'll add to > my todo to fix the rest, if no one beats me to it. Fair enough. Appended below is the updated doc part of the patch, just making the pathname -> filename change for readlink. Thanks, Ulrich Index: gdb-head/gdb/doc/gdb.texinfo =================================================================== --- gdb-head.orig/gdb/doc/gdb.texinfo 2012-01-13 18:44:34.000000000 +0100 +++ gdb-head/gdb/doc/gdb.texinfo 2012-01-16 15:03:17.000000000 +0100 @@ -17450,6 +17450,10 @@ are: @tab @code{vFile:unlink} @tab @code{remote delete} +@item @code{hostio-readlink-packet} +@tab @code{vFile:readlink} +@tab Host I/O + @item @code{noack-packet} @tab @code{QStartNoAckMode} @tab Packet acknowledgment @@ -36193,6 +36197,16 @@ error occurred. Delete the file at @var{pathname} on the target. Return 0, or -1 if an error occurs. @var{pathname} is a string. +@item vFile:readlink: @var{filename} +Read value of symbolic link @var{filename} on the target. Return +the number of bytes read, or -1 if an error occurs. + +The data read should be returned as a binary attachment on success. +If zero bytes were read, the response should include an empty binary +attachment (i.e.@: a trailing semicolon). The return value is the +number of target bytes read; the binary attachment may be longer if +some characters were escaped. + @end table @node Interrupts -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com