Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Jacobowitz <dan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/doc] Redefine the length argument in remote Z packets
Date: Fri, 29 Jan 2010 20:55:00 -0000	[thread overview]
Message-ID: <83bpgcskcc.fsf@gnu.org> (raw)
In-Reply-To: <20100129153021.GA30542@caradoc.them.org>

> Date: Fri, 29 Jan 2010 10:30:24 -0500
> From: Daniel Jacobowitz <dan@codesourcery.com>
> Cc: gdb-patches@sourceware.org
> 
> > >  Insert (@samp{Z1}) or remove (@samp{z1}) a hardware breakpoint at
> > > -address @var{addr} of size @var{length}.
> > > +address @var{addr} of size @var{kind}.
> > 
> > This is one place where it's confusing.
> 
> Because I read this four times and never saw "of size KIND".  Ack!
> 
> How's this?

We still have a few places similar to "of size KIND":

> -@item z2,@var{addr},@var{length}
> -@itemx Z2,@var{addr},@var{length}
> +@item z2,@var{addr},@var{kind}
> +@itemx Z2,@var{addr},@var{kind}
>  @cindex @samp{z2} packet
>  @cindex @samp{Z2} packet
> -Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint.
> +Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint covering
> +@var{kind} bytes at @var{addr}.

"covering KIND bytes" sounds awkward.  How about

  Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint.
  @var{kind} is 2 for watching a 2-byte region, 4 for watching a
  4-byte region.

and similarly with Z3 and Z4?

Also, here:

> +and @sc{mips} can insert either a 2 or 4 byte breakpoint.  Some
> +architectures have additional meanings for @var{kind};
> +@xref{Architecture-Specific Protocol Details}.

you want "see @ref" instead of "@xref", because the latter produces a
capitalized "See", which will look wrong after a semi-colon.


  reply	other threads:[~2010-01-29 20:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 22:29 Daniel Jacobowitz
2010-01-29  9:00 ` Eli Zaretskii
2010-01-29 15:30   ` Daniel Jacobowitz
2010-01-29 20:55     ` Eli Zaretskii [this message]
2010-01-29 21:05       ` Daniel Jacobowitz
2010-01-29 21:44         ` Eli Zaretskii
2010-02-01 16:09           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bpgcskcc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox