From: Daniel Jacobowitz <dan@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/doc] Redefine the length argument in remote Z packets
Date: Fri, 29 Jan 2010 21:05:00 -0000 [thread overview]
Message-ID: <20100129210525.GD4757@caradoc.them.org> (raw)
In-Reply-To: <83bpgcskcc.fsf@gnu.org>
On Fri, Jan 29, 2010 at 10:54:27PM +0200, Eli Zaretskii wrote:
> > -@item z2,@var{addr},@var{length}
> > -@itemx Z2,@var{addr},@var{length}
> > +@item z2,@var{addr},@var{kind}
> > +@itemx Z2,@var{addr},@var{kind}
> > @cindex @samp{z2} packet
> > @cindex @samp{Z2} packet
> > -Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint.
> > +Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint covering
> > +@var{kind} bytes at @var{addr}.
>
> "covering KIND bytes" sounds awkward. How about
>
> Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint.
> @var{kind} is 2 for watching a 2-byte region, 4 for watching a
> 4-byte region.
>
> and similarly with Z3 and Z4?
Except it really can be any number of bytes now. "@var{kind} is
interpreted as the number of bytes to watch"?
> you want "see @ref" instead of "@xref", because the latter produces a
> capitalized "See", which will look wrong after a semi-colon.
Thanks!
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-01-29 21:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 22:29 Daniel Jacobowitz
2010-01-29 9:00 ` Eli Zaretskii
2010-01-29 15:30 ` Daniel Jacobowitz
2010-01-29 20:55 ` Eli Zaretskii
2010-01-29 21:05 ` Daniel Jacobowitz [this message]
2010-01-29 21:44 ` Eli Zaretskii
2010-02-01 16:09 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129210525.GD4757@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox