From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22431 invoked by alias); 29 Jan 2010 20:55:45 -0000 Received: (qmail 22422 invoked by uid 22791); 29 Jan 2010 20:55:44 -0000 X-SWARE-Spam-Status: No, hits=0.1 required=5.0 tests=AWL,BAYES_40,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Jan 2010 20:55:40 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KX1009000LONY00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 29 Jan 2010 22:54:29 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.127.180.161]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KX10083T0QPL050@a-mtaout20.012.net.il>; Fri, 29 Jan 2010 22:54:26 +0200 (IST) Date: Fri, 29 Jan 2010 20:55:00 -0000 From: Eli Zaretskii Subject: Re: [RFA/doc] Redefine the length argument in remote Z packets In-reply-to: <20100129153021.GA30542@caradoc.them.org> To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83bpgcskcc.fsf@gnu.org> References: <20100128222940.GE2813@caradoc.them.org> <831vh9thfo.fsf@gnu.org> <20100129153021.GA30542@caradoc.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00652.txt.bz2 > Date: Fri, 29 Jan 2010 10:30:24 -0500 > From: Daniel Jacobowitz > Cc: gdb-patches@sourceware.org > > > > Insert (@samp{Z1}) or remove (@samp{z1}) a hardware breakpoint at > > > -address @var{addr} of size @var{length}. > > > +address @var{addr} of size @var{kind}. > > > > This is one place where it's confusing. > > Because I read this four times and never saw "of size KIND". Ack! > > How's this? We still have a few places similar to "of size KIND": > -@item z2,@var{addr},@var{length} > -@itemx Z2,@var{addr},@var{length} > +@item z2,@var{addr},@var{kind} > +@itemx Z2,@var{addr},@var{kind} > @cindex @samp{z2} packet > @cindex @samp{Z2} packet > -Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint. > +Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint covering > +@var{kind} bytes at @var{addr}. "covering KIND bytes" sounds awkward. How about Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint. @var{kind} is 2 for watching a 2-byte region, 4 for watching a 4-byte region. and similarly with Z3 and Z4? Also, here: > +and @sc{mips} can insert either a 2 or 4 byte breakpoint. Some > +architectures have additional meanings for @var{kind}; > +@xref{Architecture-Specific Protocol Details}. you want "see @ref" instead of "@xref", because the latter produces a capitalized "See", which will look wrong after a semi-colon.