Re: [PATCH 4/5] MI notification on trace started/stopped:basic

[Eli Zaretskii <eliz@gnu.org>]

> From: Yao Qi <yao@codesourcery.com>
> Date: Tue, 22 Jan 2013 15:03:51 +0800
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -128,6 +128,8 @@ show print type typedefs
>    ** The response to breakpoint commands and breakpoint async records
>       includes an "installed" field containing a boolean state about each
>       non-pending tracepoint location is whether installed on target or not.
> +  ** The start and stop of trace are now notified using new async records
> +     "=trace-started" and "=trace-stopped".

OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -27967,6 +27967,10 @@ written in an inferior.  The @var{id} is the identifier of the
>  thread group corresponding to the affected inferior.  The optional
>  @code{type="code"} part is reported if the memory written to holds
>  executable code.
> +
> +@item =trace-started
> +@itemx =trace-stopped
> +Reports that trace was started or stopped.
>  @end table
>  
>  @node GDB/MI Breakpoint Information

OK.

> --- a/gdb/doc/observer.texi
> +++ b/gdb/doc/observer.texi
> @@ -246,6 +246,12 @@ The trace state variable @var{name} is deleted.  If @var{name} is
>  @code{NULL}, all trace state variables are deleted.
>  @end deftypefun
>  
> +@deftypefun void trace_changed (int @var{started})
> +The status of trace in @value{GDBN} has changed.  The trace is started
> +if @var{started} is true, and the trace is stopped if @var{started} is
> +false.

"true" and "false" or "non-zero" and "zero"?  This is C, and we don't
use the boolean types in the above deftypefun.

Thanks.