From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/5] Query supported notifications by qSupported
Date: Sat, 16 Feb 2013 09:33:00 -0000 [thread overview]
Message-ID: <8338wwsiwk.fsf@gnu.org> (raw)
In-Reply-To: <1360987214-16592-3-git-send-email-yao@codesourcery.com>
> From: Yao Qi <yao@codesourcery.com>
> Date: Sat, 16 Feb 2013 12:00:11 +0800
>
> As we we adding more notifications and annexes, both GDB and GDBserver
> has to know what notifications and annexes are supported in the other
> side. This is what this patch does. When GDB connects to GDBserver,
> it will happen:
>
> --> qSupported:XXX;notifications=N1,N2.A1.A2,N3
> (GDB supports notification N1, N2 with annexes A1,A2, and N3)
This form is not described in your patch for the manual.
> +@item notifications
> +@anchor{notifications feature}
> +This feature indicates that @value{GDBN} supports the async remote
> +notifications (@pxref{Notification Packets}). If the stub sees
> +@samp{notifications=} with a string of supported notifications,
> +separated by commas, it will report notifications supported by the
> +stub.
See above: I think you should show here the form of the
"notifications=" part in more detail. In particular, the fact that
each notification is of the form NOTIFICATION.ANNEX1.ANNEX2... is
important and should be described and the meaning of the multiple
ANNEX parts explained.
> +@item Notifications=@var{name}@r{[}.@var{annex}@r{]}@dots{}@r{[},@var{name}@r{[}.@var{annex}@r{]}@dots{}@r{]}@dots{}
> +@cindex notifications, in remote protocol
> +The remote stub supports a string of notifications. @var{name} is
> +the name of the notification and @var{annex} is the name of the annex,
> +if the notification has the annex.
Here, too, we should say explicitly that there could be several
@var{annex} parts separated by periods.
OK with those changes.
Thanks.
next prev parent reply other threads:[~2013-02-16 9:33 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 7:05 [PATCH 0/5] MI notification on trace started/stopped (V3) Yao Qi
2013-01-22 7:05 ` [PATCH 1/5] Add annex in a async remote notification Yao Qi
2013-01-22 8:06 ` Eli Zaretskii
2013-02-16 3:40 ` Yao Qi
2013-02-16 9:27 ` Eli Zaretskii
2013-03-29 17:17 ` Yao Qi
2013-03-31 0:39 ` Eli Zaretskii
2013-01-22 7:05 ` [PATCH 3/5] async remote notification 'Trace' Yao Qi
2013-01-22 8:06 ` Eli Zaretskii
2013-01-22 7:05 ` [PATCH 2/5] Query supported notifications by qSupported Yao Qi
2013-01-22 8:09 ` Eli Zaretskii
2013-01-22 8:41 ` Yao Qi
2013-01-22 10:26 ` Eli Zaretskii
2013-01-22 7:06 ` [PATCH 5/5] MI notification on trace stop: triggered by remote Yao Qi
2013-01-22 7:06 ` [PATCH 4/5] MI notification on trace started/stopped:basic Yao Qi
2013-01-22 8:11 ` Eli Zaretskii
2013-01-30 4:00 ` [ping]: [PATCH 0/5] MI notification on trace started/stopped (V3) Yao Qi
2013-02-07 12:41 ` [ping 2]: " Yao Qi
2013-02-16 4:01 ` [PATCH 0/5] MI notification on trace started/stopped (V3.1) Yao Qi
2013-02-16 4:01 ` [PATCH 1/5] Add annex in a async remote notification Yao Qi
2013-02-16 9:27 ` Eli Zaretskii
2013-02-16 4:02 ` [PATCH 3/5] async remote notification 'Trace' Yao Qi
2013-02-16 9:34 ` Eli Zaretskii
2013-02-16 4:02 ` [PATCH 2/5] Query supported notifications by qSupported Yao Qi
2013-02-16 9:33 ` Eli Zaretskii [this message]
2013-03-11 9:26 ` Yao Qi
2013-03-11 16:59 ` Eli Zaretskii
2013-02-16 4:02 ` [PATCH 5/5] MI notification on trace stop: triggered by remote Yao Qi
2013-02-16 4:02 ` [PATCH 4/5] MI notification on trace started/stopped:basic Yao Qi
2013-02-16 9:36 ` Eli Zaretskii
2013-02-25 3:14 ` ping: [PATCH 0/5] MI notification on trace started/stopped (V3.1) Yao Qi
2013-03-04 2:34 ` ping^2 : " Yao Qi
2013-04-02 2:33 ` [PATCH v4 0/5] MI notification on trace started/stopped Yao Qi
2013-04-02 3:15 ` [PATCH 2/5] Query supported notifications by qSupported Yao Qi
2013-04-02 3:58 ` [PATCH 3/5] async remote notification 'Trace' Yao Qi
2013-04-02 12:46 ` [PATCH 5/5] MI notification on trace stop: triggered by remote Yao Qi
2013-04-02 13:07 ` [PATCH 4/5] MI notification on trace started/stopped:basic Yao Qi
2013-04-02 13:30 ` [PATCH 1/5] Add annex in a async remote notification Yao Qi
2013-04-10 15:46 ` [PATCH v4 0/5] MI notification on trace started/stopped Yao Qi
2013-04-17 14:37 ` [ping 2]: " Yao Qi
2013-04-18 15:16 ` Pedro Alves
2013-04-18 16:14 ` Yao Qi
2013-06-04 9:20 ` Yao Qi
2014-01-24 9:43 [PATCH 0/5 V8] " Yao Qi
2014-01-24 9:43 ` [PATCH 2/5] Query supported notifications by qSupported Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8338wwsiwk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox