From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23304 invoked by alias); 22 Jan 2013 08:11:33 -0000 Received: (qmail 23286 invoked by uid 22791); 22 Jan 2013 08:11:31 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_NIX_SPAM,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Jan 2013 08:11:28 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MH000B00PBVT900@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 22 Jan 2013 10:10:38 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MH000BR3PDQS020@a-mtaout22.012.net.il>; Tue, 22 Jan 2013 10:10:38 +0200 (IST) Date: Tue, 22 Jan 2013 08:11:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 4/5] MI notification on trace started/stopped:basic In-reply-to: <1358838232-13319-5-git-send-email-yao@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83bochocxb.fsf@gnu.org> References: <1358838232-13319-1-git-send-email-yao@codesourcery.com> <1358838232-13319-5-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00515.txt.bz2 > From: Yao Qi > Date: Tue, 22 Jan 2013 15:03:51 +0800 > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -128,6 +128,8 @@ show print type typedefs > ** The response to breakpoint commands and breakpoint async records > includes an "installed" field containing a boolean state about each > non-pending tracepoint location is whether installed on target or not. > + ** The start and stop of trace are now notified using new async records > + "=trace-started" and "=trace-stopped". OK. > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -27967,6 +27967,10 @@ written in an inferior. The @var{id} is the identifier of the > thread group corresponding to the affected inferior. The optional > @code{type="code"} part is reported if the memory written to holds > executable code. > + > +@item =trace-started > +@itemx =trace-stopped > +Reports that trace was started or stopped. > @end table > > @node GDB/MI Breakpoint Information OK. > --- a/gdb/doc/observer.texi > +++ b/gdb/doc/observer.texi > @@ -246,6 +246,12 @@ The trace state variable @var{name} is deleted. If @var{name} is > @code{NULL}, all trace state variables are deleted. > @end deftypefun > > +@deftypefun void trace_changed (int @var{started}) > +The status of trace in @value{GDBN} has changed. The trace is started > +if @var{started} is true, and the trace is stopped if @var{started} is > +false. "true" and "false" or "non-zero" and "zero"? This is C, and we don't use the boolean types in the above deftypefun. Thanks.