From: Eli Zaretskii <eliz@gnu.org>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Consistently quote variables used with "test"
Date: Thu, 19 Dec 2019 03:30:00 -0000 [thread overview]
Message-ID: <83a77p2drw.fsf@gnu.org> (raw)
In-Reply-To: <20191218210608.211751-1-cbiesinger@google.com> (gdb-patches@sourceware.org)
> Date: Wed, 18 Dec 2019 15:06:08 -0600
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Cc: Christian Biesinger <cbiesinger@google.com>
>
> This ensures that empty variables and variables with spaces are handled
> correctly.
>
> Code was inconsistent on whether the constant string (e.g. yes/no)
> should also be quoted; I tried to be consistent with surrounding code.
>
> This fixes the error Eli reported during configure with mingw (though that
> was not fatal).
Thanks.
next prev parent reply other threads:[~2019-12-19 3:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 21:06 Christian Biesinger via gdb-patches
2019-12-19 3:30 ` Eli Zaretskii [this message]
2019-12-19 19:24 ` Tom Tromey
2019-12-19 19:32 ` Christian Biesinger via gdb-patches
2019-12-26 7:51 ` Christian Biesinger via gdb-patches
2019-12-26 16:16 ` Simon Marchi
2019-12-26 22:36 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a77p2drw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox