From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Consistently quote variables used with "test"
Date: Thu, 26 Dec 2019 07:51:00 -0000 [thread overview]
Message-ID: <CAPTJ0XHV=5aupqjv1g0U+3+ZAmkgVpVo8L91gaiYikd35RvaDA@mail.gmail.com> (raw)
In-Reply-To: <CAPTJ0XHUo3jPY-QMToDWW_OxDsh7SQrQGqsPBVgo9HnSrw=H=Q@mail.gmail.com>
On Thu, Dec 19, 2019 at 8:31 PM Christian Biesinger
<cbiesinger@google.com> wrote:
>
> On Thu, Dec 19, 2019 at 1:24 PM Tom Tromey <tom@tromey.com> wrote:
> >
> > >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
> >
> > Christian> This ensures that empty variables and variables with spaces are handled
> > Christian> correctly.
> >
> > Christian> Code was inconsistent on whether the constant string (e.g. yes/no)
> > Christian> should also be quoted; I tried to be consistent with surrounding code.
> >
> > Christian> This fixes the error Eli reported during configure with mingw (though that
> > Christian> was not fatal).
> >
> > Thanks. This is ok.
>
> Thanks, pushed.
> To ssh://sourceware.org/git/binutils-gdb.git
> 1ee7b812e7..0ad6b8ee70 HEAD -> master
I just realized I only pushed this to trunk, whereas Eli reported this
issue on the gdb 9 branch. OK to push this to the branch as well?
Christian
next prev parent reply other threads:[~2019-12-26 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 21:06 Christian Biesinger via gdb-patches
2019-12-19 3:30 ` Eli Zaretskii
2019-12-19 19:24 ` Tom Tromey
2019-12-19 19:32 ` Christian Biesinger via gdb-patches
2019-12-26 7:51 ` Christian Biesinger via gdb-patches [this message]
2019-12-26 16:16 ` Simon Marchi
2019-12-26 22:36 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XHV=5aupqjv1g0U+3+ZAmkgVpVo8L91gaiYikd35RvaDA@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox