From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35938 invoked by alias); 19 Dec 2019 03:30:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35916 invoked by uid 89); 19 Dec 2019 03:30:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:2116 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 03:30:36 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ihmWD-0006WC-1n; Wed, 18 Dec 2019 22:30:29 -0500 Received: from [176.228.60.248] (port=2116 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ihmW3-0000IA-Sw; Wed, 18 Dec 2019 22:30:27 -0500 Date: Thu, 19 Dec 2019 03:30:00 -0000 Message-Id: <83a77p2drw.fsf@gnu.org> From: Eli Zaretskii To: Christian Biesinger CC: gdb-patches@sourceware.org In-reply-to: <20191218210608.211751-1-cbiesinger@google.com> (gdb-patches@sourceware.org) Subject: Re: [PATCH] Consistently quote variables used with "test" References: <20191218210608.211751-1-cbiesinger@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00807.txt.bz2 > Date: Wed, 18 Dec 2019 15:06:08 -0600 > From: "Christian Biesinger via gdb-patches" > Cc: Christian Biesinger > > This ensures that empty variables and variables with spaces are handled > correctly. > > Code was inconsistent on whether the constant string (e.g. yes/no) > should also be quoted; I tried to be consistent with surrounding code. > > This fixes the error Eli reported during configure with mingw (though that > was not fatal). Thanks.