From: Eli Zaretskii <eliz@gnu.org>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: JIT Reader
Date: Thu, 03 Nov 2011 17:13:00 -0000 [thread overview]
Message-ID: <838vnxm8or.fsf@gnu.org> (raw)
In-Reply-To: <4EB2C49A.2020001@playingwithpointers.com>
> Date: Thu, 03 Nov 2011 22:13:06 +0530
> From: Sanjoy Das <sanjoy@playingwithpointers.com>
> CC: gdb-patches@sourceware.org
>
> New patches attached. Fixed the formatting errors, refactored
> jit_reader_try_read_symtab to remove the label and the gotos
> altogether, and fixed a small typo in the docs that I had overlooked.
> Everything else is the same.
Thanks.
> +runtime). Two new @value{GDBN} commands, @code{jit-reader-load} and
^^^
Please delete "new" here. The manual is supposed to be time-agnostic ;-)
> +will usually result load @file{@var{libdir}/gdb/@var{reader-name}},
"result" is redundant here, please remove it.
> +@item jit-reader-unload
> +
> +Unload the currently loaded JIT reader.
Please don't leave an empty line between @item in a @table and the
following description.
> +@node Writing JIT Debug Info Readers
> +@subsection Writing JIT Debug Info Readers
@cindex entry (with the same text as the subsection name, just in
lower-case, except "JIT") would be good here.
OK with these changes.
next prev parent reply other threads:[~2011-11-03 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 9:41 Sanjoy Das
2011-11-02 17:52 ` Tom Tromey
2011-11-02 18:04 ` Tom Tromey
2011-11-02 18:30 ` Tom Tromey
2011-11-02 18:38 ` Tom Tromey
2011-11-03 10:38 ` Sanjoy Das
2011-11-03 14:37 ` Tom Tromey
2011-11-03 14:38 ` Tom Tromey
2011-11-03 14:39 ` Tom Tromey
2011-11-03 16:39 ` Sanjoy Das
2011-11-03 17:13 ` Eli Zaretskii [this message]
2011-11-03 17:55 ` Sanjoy Das
2011-11-04 2:58 ` Sanjoy Das
2011-11-04 13:49 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838vnxm8or.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=sanjoy@playingwithpointers.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox