From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24021 invoked by alias); 3 Nov 2011 17:13:38 -0000 Received: (qmail 24013 invoked by uid 22791); 3 Nov 2011 17:13:38 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Nov 2011 17:13:19 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LU300500H2A0900@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 03 Nov 2011 19:12:34 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.228.70.69]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LU3004YWH4WWR30@a-mtaout20.012.net.il>; Thu, 03 Nov 2011 19:12:33 +0200 (IST) Date: Thu, 03 Nov 2011 17:13:00 -0000 From: Eli Zaretskii Subject: Re: JIT Reader In-reply-to: <4EB2C49A.2020001@playingwithpointers.com> To: Sanjoy Das Cc: tromey@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <838vnxm8or.fsf@gnu.org> References: <4EA9095D.5070408@playingwithpointers.com> <4EB26FF7.1070102@playingwithpointers.com> <4EB2C49A.2020001@playingwithpointers.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00086.txt.bz2 > Date: Thu, 03 Nov 2011 22:13:06 +0530 > From: Sanjoy Das > CC: gdb-patches@sourceware.org > > New patches attached. Fixed the formatting errors, refactored > jit_reader_try_read_symtab to remove the label and the gotos > altogether, and fixed a small typo in the docs that I had overlooked. > Everything else is the same. Thanks. > +runtime). Two new @value{GDBN} commands, @code{jit-reader-load} and ^^^ Please delete "new" here. The manual is supposed to be time-agnostic ;-) > +will usually result load @file{@var{libdir}/gdb/@var{reader-name}}, "result" is redundant here, please remove it. > +@item jit-reader-unload > + > +Unload the currently loaded JIT reader. Please don't leave an empty line between @item in a @table and the following description. > +@node Writing JIT Debug Info Readers > +@subsection Writing JIT Debug Info Readers @cindex entry (with the same text as the subsection name, just in lower-case, except "JIT") would be good here. OK with these changes.