From: Tom Tromey <tromey@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: JIT Reader
Date: Thu, 03 Nov 2011 14:37:00 -0000 [thread overview]
Message-ID: <m3fwi5tgqo.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4EB26FF7.1070102@playingwithpointers.com> (Sanjoy Das's message of "Thu, 03 Nov 2011 16:11:59 +0530")
>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:
Sanjoy> +void *gdb_dlopen(const char *filename)
Sanjoy> +{
Sanjoy> + gdb_assert_not_reached ("gdb_dlopen should not be called on this platform.");
Sanjoy> + return NULL;
Sanjoy> +}
Wrong formatting -- the GNU style puts the function name at the start of
the line. This is true for all the new functions.
gdb_assert_not_reached does not return, so you don't need a 'return'
here. Also true in all the new functions.
Tom
next prev parent reply other threads:[~2011-11-03 14:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 9:41 Sanjoy Das
2011-11-02 17:52 ` Tom Tromey
2011-11-02 18:04 ` Tom Tromey
2011-11-02 18:30 ` Tom Tromey
2011-11-02 18:38 ` Tom Tromey
2011-11-03 10:38 ` Sanjoy Das
2011-11-03 14:37 ` Tom Tromey [this message]
2011-11-03 14:38 ` Tom Tromey
2011-11-03 14:39 ` Tom Tromey
2011-11-03 16:39 ` Sanjoy Das
2011-11-03 17:13 ` Eli Zaretskii
2011-11-03 17:55 ` Sanjoy Das
2011-11-04 2:58 ` Sanjoy Das
2011-11-04 13:49 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fwi5tgqo.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sanjoy@playingwithpointers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox