Re: [PATCH] gdb: Add support for dumping to verilog hex format.

[Eli Zaretskii <eliz@gnu.org>]

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 22 Apr 2015 23:24:59 +0100
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 62cbdcb..6ad68ac 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -42,6 +42,8 @@
>    (no "set sysroot" or "file" commands are required).  See "New remote
>    packets" below.
>  
> +* The "dump" command now supports verilog hex format.

This part is OK.

>  static void
> +verilog_dump_command (char *cmd, int from_tty)
> +{
> +  printf_unfiltered ("\"dump verilog\" must be followed by a subcommand.\n");

Shouldn't this message be in _()?

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 0410702..4b78fb4 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -10890,6 +10890,8 @@ Intel hex format.
>  Motorola S-record format.
>  @item tekhex
>  Tektronix Hex format.
> +@item verilog
> +Verilog Hex format.
>  @end table
>  
>  @value{GDBN} uses the same definitions of these formats as the

OK for this part.

Thanks.