From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-122270-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 120156 invoked by alias); 23 Apr 2015 06:18:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 120128 invoked by uid 89); 23 Apr 2015 06:18:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout28.012.net.il
Received: from mtaout28.012.net.il (HELO mtaout28.012.net.il) (80.179.55.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Apr 2015 06:17:59 +0000
Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NN800O00X37A600@mtaout28.012.net.il> for gdb-patches@sourceware.org; Thu, 23 Apr 2015 09:16:44 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NN800M5KXFW9530@mtaout28.012.net.il>; Thu, 23 Apr 2015 09:16:44 +0300 (IDT)
Date: Thu, 23 Apr 2015 06:18:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] gdb: Add support for dumping to verilog hex format.
In-reply-to: <ac8db75957e27b34d78e2f0b692b5072a9809a37.1429740646.git.andrew.burgess@embecosm.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <838udj2wru.fsf@gnu.org>
References: <ac8db75957e27b34d78e2f0b692b5072a9809a37.1429740646.git.andrew.burgess@embecosm.com>
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg00858.txt.bz2

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Wed, 22 Apr 2015 23:24:59 +0100
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 62cbdcb..6ad68ac 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -42,6 +42,8 @@
>    (no "set sysroot" or "file" commands are required).  See "New remote
>    packets" below.
>  
> +* The "dump" command now supports verilog hex format.

This part is OK.

>  static void
> +verilog_dump_command (char *cmd, int from_tty)
> +{
> +  printf_unfiltered ("\"dump verilog\" must be followed by a subcommand.\n");

Shouldn't this message be in _()?

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 0410702..4b78fb4 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -10890,6 +10890,8 @@ Intel hex format.
>  Motorola S-record format.
>  @item tekhex
>  Tektronix Hex format.
> +@item verilog
> +Verilog Hex format.
>  @end table
>  
>  @value{GDBN} uses the same definitions of these formats as the

OK for this part.

Thanks.