From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Add support for dumping to verilog hex format.
Date: Thu, 23 Apr 2015 21:34:00 -0000 [thread overview]
Message-ID: <20150423213414.GI2422@embecosm.com> (raw)
In-Reply-To: <5538CC57.6030305@redhat.com>
* Pedro Alves <palves@redhat.com> [2015-04-23 11:41:27 +0100]:
> Thanks, this looks good to me with the missing _() Eli noticed, and ...
The _() I wised was a result of copy 'n' pasting some code that
already lacks internationalisation support. This patch fixes those
strings in the immediate area of where I was working.
This applies on top of the verilog dump patch, and I'll push it as
obvious once that patch is merged.
Thanks,
Andrew
--
Spotted a few strings that were missing internationalization support.
gdb/ChangeLog:
* cli/cli-dump.c (srec_dump_command): Add internationalization
mark ups.
(ihex_dump_command): Likewise.
(tekhex_dump_command): Likewise.
(binary_dump_command): Likewise.
(binary_append_command): Likewise.
---
gdb/ChangeLog | 9 +++++++++
gdb/cli/cli-dump.c | 10 +++++-----
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 410f1b7..08912fd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2015-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
+
+ * cli/cli-dump.c (srec_dump_command): Add internationalization
+ mark ups.
+ (ihex_dump_command): Likewise.
+ (tekhex_dump_command): Likewise.
+ (binary_dump_command): Likewise.
+ (binary_append_command): Likewise.
+
2015-04-22 Andrew Burgess <andrew.burgess@embecosm.com>
* cli/cli-dump.c (verilog_cmdlist): New variable.
diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c
index 08ff941..2449dc5 100644
--- a/gdb/cli/cli-dump.c
+++ b/gdb/cli/cli-dump.c
@@ -637,14 +637,14 @@ restore_command (char *args_in, int from_tty)
static void
srec_dump_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"dump srec\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"dump srec\" must be followed by a subcommand.\n"));
help_list (srec_cmdlist, "dump srec ", all_commands, gdb_stdout);
}
static void
ihex_dump_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"dump ihex\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"dump ihex\" must be followed by a subcommand.\n"));
help_list (ihex_cmdlist, "dump ihex ", all_commands, gdb_stdout);
}
@@ -658,21 +658,21 @@ verilog_dump_command (char *cmd, int from_tty)
static void
tekhex_dump_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"dump tekhex\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"dump tekhex\" must be followed by a subcommand.\n"));
help_list (tekhex_cmdlist, "dump tekhex ", all_commands, gdb_stdout);
}
static void
binary_dump_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"dump binary\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"dump binary\" must be followed by a subcommand.\n"));
help_list (binary_dump_cmdlist, "dump binary ", all_commands, gdb_stdout);
}
static void
binary_append_command (char *cmd, int from_tty)
{
- printf_unfiltered ("\"append binary\" must be followed by a subcommand.\n");
+ printf_unfiltered (_("\"append binary\" must be followed by a subcommand.\n"));
help_list (binary_append_cmdlist, "append binary ", all_commands,
gdb_stdout);
}
--
2.2.2
next prev parent reply other threads:[~2015-04-23 21:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 22:25 Andrew Burgess
2015-04-22 22:33 ` Pedro Alves
2015-04-22 23:04 ` Andrew Burgess
2015-04-23 10:41 ` Pedro Alves
2015-04-23 21:31 ` Andrew Burgess
2015-04-24 6:17 ` Eli Zaretskii
2015-04-24 13:50 ` Pedro Alves
2015-04-23 21:34 ` Andrew Burgess [this message]
2015-04-24 13:51 ` Pedro Alves
2015-04-23 6:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423213414.GI2422@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox