Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: implement "catch signal"
Date: Fri, 16 Nov 2012 19:49:00 -0000	[thread overview]
Message-ID: <834nkp49dl.fsf@gnu.org> (raw)
In-Reply-To: <874nkpv03j.fsf@fleche.redhat.com>

> From: Tom Tromey <tromey@redhat.com>
> Date: Fri, 16 Nov 2012 12:06:40 -0700
> 
> This patch implements "catch signal".  I took Pedro's unfinished "catch
> signal" patch and worked on it a bit.
> 
> This needs a doc review at least.

Thanks.  The doc is OK, with the exception of one comment:

> +When a signal is caught by a catchpoint, the signal's @code{stop} and
> +@code{print} settings, as specified by @code{handle}, are ignored.
> +However, whether the signal is still delivered to the inferior depends
> +on the @code{pass} setting; this can be changed in the catchpoint's
> +commands.

I suggest to make the last part of this less vague, by saying _how_
that can be changed.


  reply	other threads:[~2012-11-16 19:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-16 19:07 Tom Tromey
2012-11-16 19:49 ` Eli Zaretskii [this message]
2012-11-17  2:22 ` Yao Qi
2012-12-02  9:38 ` Jan Kratochvil
2012-12-03 18:59   ` Tom Tromey
2012-12-03 19:37     ` Jan Kratochvil
2012-12-03 19:39       ` Tom Tromey
2012-12-03 20:22         ` André Pönitz
2012-12-03 20:31           ` Jan Kratochvil
2012-12-07 18:42             ` Tom Tromey
2012-12-07 19:28               ` Jan Kratochvil
2012-12-07 19:47                 ` Tom Tromey
2012-12-07 20:04                   ` Jan Kratochvil
2012-12-17 21:43                     ` Tom Tromey
2012-12-18 16:39                       ` Jan Kratochvil
2012-12-18 16:45                         ` Tom Tromey
2012-12-18 16:50                           ` Jan Kratochvil
2012-12-19 19:32                       ` Tom Tromey
2012-12-19 20:11                         ` Marc Khouzam
2012-12-20  8:58                         ` Dodji Seketeli
2013-01-03 18:06                           ` Tom Tromey
2012-12-07 18:41           ` Tom Tromey
2013-01-03 18:16     ` RFA: [1/2] add "catch-type" to all catchpoints Tom Tromey
2013-01-03 18:39       ` Eli Zaretskii
2013-01-16 17:23       ` Tom Tromey
2013-01-03 18:23     ` RFA: [2/2] catch signal Tom Tromey
2013-01-16 17:28       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834nkp49dl.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox