From: "André Pönitz" <andre.poenitz@mathematik.tu-chemnitz.de>
To: Tom Tromey <tromey@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: RFC: implement "catch signal"
Date: Mon, 03 Dec 2012 20:22:00 -0000 [thread overview]
Message-ID: <20121203202233.GA23933@klara.mpi.htwm.de> (raw)
In-Reply-To: <87obibvsb1.fsf@fleche.redhat.com>
On Mon, Dec 03, 2012 at 12:39:30PM -0700, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> That MI output is now:
>
> Jan> body=[bkpt={number="1",type="catchpoint",disp="keep",enabled="y",what=[signal="SIGINT",signal="SIGTRAP"],times="0"}]
>
> Jan> vs. for example existing:
>
> Jan> body=[bkpt={number="3",type="catchpoint",disp="keep",enabled="y",what="<any
> syscall> ",times="0"}]
>
> Jan> but maybe it is OK this way, MI parsing has never been easy.
>
> Yes, I think it is clearly better this way: we use MI constructs for
> representing lists and such.
>
> The "type" of the "what" field is now a bit variable.
> That is, it can either be a list or a string, depending on the signal
> catchpoint.
As a more general remark from a MI consumer's perspective: It's nicer to not
change existing fields, but instead add new ones.
I understand that changing values is formally covered by the "guarantees" in
sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Development-and-Front-Ends.html,
as this is covered by "The range of values for fields with specified values
[...] may be extended" but I would like to think that the basic idea behind
writing those rules was to not break consumers of existing MI output when
extending that output. A preference of adding new fields over changing
contents (or even "type" of existing fields) should increase the chance
that frontends don't break, and can adjust to the change at their own pace.
Andre'
next prev parent reply other threads:[~2012-12-03 20:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 19:07 Tom Tromey
2012-11-16 19:49 ` Eli Zaretskii
2012-11-17 2:22 ` Yao Qi
2012-12-02 9:38 ` Jan Kratochvil
2012-12-03 18:59 ` Tom Tromey
2012-12-03 19:37 ` Jan Kratochvil
2012-12-03 19:39 ` Tom Tromey
2012-12-03 20:22 ` André Pönitz [this message]
2012-12-03 20:31 ` Jan Kratochvil
2012-12-07 18:42 ` Tom Tromey
2012-12-07 19:28 ` Jan Kratochvil
2012-12-07 19:47 ` Tom Tromey
2012-12-07 20:04 ` Jan Kratochvil
2012-12-17 21:43 ` Tom Tromey
2012-12-18 16:39 ` Jan Kratochvil
2012-12-18 16:45 ` Tom Tromey
2012-12-18 16:50 ` Jan Kratochvil
2012-12-19 19:32 ` Tom Tromey
2012-12-19 20:11 ` Marc Khouzam
2012-12-20 8:58 ` Dodji Seketeli
2013-01-03 18:06 ` Tom Tromey
2012-12-07 18:41 ` Tom Tromey
2013-01-03 18:16 ` RFA: [1/2] add "catch-type" to all catchpoints Tom Tromey
2013-01-03 18:39 ` Eli Zaretskii
2013-01-16 17:23 ` Tom Tromey
2013-01-03 18:23 ` RFA: [2/2] catch signal Tom Tromey
2013-01-16 17:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203202233.GA23933@klara.mpi.htwm.de \
--to=andre.poenitz@mathematik.tu-chemnitz.de \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox