From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96035-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2953 invoked by alias); 16 Nov 2012 19:49:02 -0000
Received: (qmail 2945 invoked by uid 22791); 16 Nov 2012 19:49:02 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Nov 2012 19:48:57 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MDL00G00J1G6T00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 16 Nov 2012 21:48:53 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MDL00FHSJ1G81J0@a-mtaout20.012.net.il>; Fri, 16 Nov 2012 21:48:53 +0200 (IST)
Date: Fri, 16 Nov 2012 19:49:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: RFC: implement "catch signal"
In-reply-to: <874nkpv03j.fsf@fleche.redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834nkp49dl.fsf@gnu.org>
References: <874nkpv03j.fsf@fleche.redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00473.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Date: Fri, 16 Nov 2012 12:06:40 -0700
> 
> This patch implements "catch signal".  I took Pedro's unfinished "catch
> signal" patch and worked on it a bit.
> 
> This needs a doc review at least.

Thanks.  The doc is OK, with the exception of one comment:

> +When a signal is caught by a catchpoint, the signal's @code{stop} and
> +@code{print} settings, as specified by @code{handle}, are ignored.
> +However, whether the signal is still delivered to the inferior depends
> +on the @code{pass} setting; this can be changed in the catchpoint's
> +commands.

I suggest to make the last part of this less vague, by saying _how_
that can be changed.