Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: markus.t.metzger@intel.com
Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com,
	palves@redhat.com, tromey@redhat.com, kettenis@gnu.org
Subject: Re: [patch v5 07/12] btrace, doc: document remote serial protocol
Date: Fri, 07 Dec 2012 15:09:00 -0000	[thread overview]
Message-ID: <834njxoq7g.fsf@gnu.org> (raw)
In-Reply-To: <1354876644-25749-8-git-send-email-markus.t.metzger@intel.com>

> From: markus.t.metzger@intel.com
> Cc: markus.t.metzger@gmail.com, jan.kratochvil@redhat.com, palves@redhat.com,        tromey@redhat.com, kettenis@gnu.org,        Markus Metzger <markus.t.metzger@intel.com>
> Date: Fri,  7 Dec 2012 11:37:19 +0100
> 
> From: Markus Metzger <markus.t.metzger@intel.com>
> 
> Document the extensions to the remote serial protocol for supporting branch tracing.
> 
> 2012-12-07 Markus Metzger <markus.t.metzger@intel.com>
> 
> doc/
> 	* gdb.texinfo (Requirements): List qXfer:btrace:read requiring expat.
> 	(General Query Packets): Describe qbtrace, Qbtrace, and qXfer:btrace:read.

Thanks.

> +Return a description of the current branch trace.
> +@xref{Branch Trace Format}.  The annex part of the generic @samp{qXfer}
> +packet contains the thread id (see @ref{thread-id syntax}) for which
                                  ^^^^^^^^
Please use @pxref instead of "see @ref".

> +In order to display the branch trace of an inferior thread,
> +@value{GDBN} needs to obtain the list of branches. This list is

Two spaces between sentences, please (here and elsewhere in the
patch).

OK with those changes.


  reply	other threads:[~2012-12-07 15:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07 10:37 [patch v5 00/12] branch tracing support for Atom markus.t.metzger
2012-12-07 10:37 ` [patch v5 09/12] gdbserver, linux, btrace: add btrace support for linux-low markus.t.metzger
2012-12-07 10:37 ` [patch v5 06/12] remote, btrace: add branch trace remote ops markus.t.metzger
2012-12-07 10:38 ` [patch v5 04/12] linux, i386, amd64: enable btrace for 32bit and 64bit linux native markus.t.metzger
2012-12-07 10:38 ` [patch v5 07/12] btrace, doc: document remote serial protocol markus.t.metzger
2012-12-07 15:09   ` Eli Zaretskii [this message]
2012-12-13  8:43     ` Metzger, Markus T
2012-12-13 17:02       ` Eli Zaretskii
2012-12-13 17:09       ` Pedro Alves
2012-12-14  7:53         ` Metzger, Markus T
2012-12-07 10:38 ` [patch v5 12/12] btrace, x86: disable on some processors markus.t.metzger
2012-12-07 10:38 ` [patch v5 10/12] test, btrace: add branch tracing tests markus.t.metzger
2012-12-07 10:38 ` [patch v5 08/12] gdbserver, btrace: add generic btrace support markus.t.metzger
2012-12-07 10:38 ` [patch v5 05/12] xml, btrace: define btrace xml document style markus.t.metzger
2012-12-07 10:38 ` [patch v5 03/12] linux, btrace: perf_event based branch tracing markus.t.metzger
2012-12-07 10:38 ` [patch v5 01/12] thread, btrace: add generic branch trace support markus.t.metzger
2012-12-07 10:38 ` [patch v5 02/12] cli, btrace: add btrace cli markus.t.metzger
2012-12-07 15:16   ` Eli Zaretskii
2012-12-13  9:14     ` Metzger, Markus T
2012-12-07 10:39 ` [patch v5 11/12] test, btrace: more branch tracing tests markus.t.metzger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834njxoq7g.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=kettenis@gnu.org \
    --cc=markus.t.metzger@intel.com \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox