From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96702-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17435 invoked by alias); 7 Dec 2012 15:09:17 -0000
Received: (qmail 17426 invoked by uid 22791); 7 Dec 2012 15:09:16 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 15:09:12 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MEO00B002174600@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 07 Dec 2012 17:08:22 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MEO00A1121XRR50@a-mtaout22.012.net.il>; Fri, 07 Dec 2012 17:08:21 +0200 (IST)
Date: Fri, 07 Dec 2012 15:09:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch v5 07/12] btrace, doc: document remote serial protocol
In-reply-to: <1354876644-25749-8-git-send-email-markus.t.metzger@intel.com>
To: markus.t.metzger@intel.com
Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com, palves@redhat.com, tromey@redhat.com, kettenis@gnu.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <834njxoq7g.fsf@gnu.org>
References: <1354876644-25749-1-git-send-email-markus.t.metzger@intel.com> <1354876644-25749-8-git-send-email-markus.t.metzger@intel.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-12/txt/msg00175.txt.bz2

> From: markus.t.metzger@intel.com
> Cc: markus.t.metzger@gmail.com, jan.kratochvil@redhat.com, palves@redhat.com,        tromey@redhat.com, kettenis@gnu.org,        Markus Metzger <markus.t.metzger@intel.com>
> Date: Fri,  7 Dec 2012 11:37:19 +0100
> 
> From: Markus Metzger <markus.t.metzger@intel.com>
> 
> Document the extensions to the remote serial protocol for supporting branch tracing.
> 
> 2012-12-07 Markus Metzger <markus.t.metzger@intel.com>
> 
> doc/
> 	* gdb.texinfo (Requirements): List qXfer:btrace:read requiring expat.
> 	(General Query Packets): Describe qbtrace, Qbtrace, and qXfer:btrace:read.

Thanks.

> +Return a description of the current branch trace.
> +@xref{Branch Trace Format}.  The annex part of the generic @samp{qXfer}
> +packet contains the thread id (see @ref{thread-id syntax}) for which
                                  ^^^^^^^^
Please use @pxref instead of "see @ref".

> +In order to display the branch trace of an inferior thread,
> +@value{GDBN} needs to obtain the list of branches. This list is

Two spaces between sentences, please (here and elsewhere in the
patch).

OK with those changes.