Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii via Gdb-patches <gdb-patches@sourceware.org>
To: Felix Willgerodt <felix.willgerodt@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] gdb, gdbserver: Add AMX registers.
Date: Fri, 06 May 2022 15:25:02 +0300	[thread overview]
Message-ID: <834k2226ht.fsf@gnu.org> (raw)
In-Reply-To: <20220506121226.137608-3-felix.willgerodt@intel.com> (message from Felix Willgerodt via Gdb-patches on Fri, 6 May 2022 14:12:24 +0200)

> Date: Fri,  6 May 2022 14:12:24 +0200
> From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> 
> +@subsubsection Intel @dfn{Advanced Matrix Extensions} (AMX).
> +@cindex Advanced Matrix Extensions (AMX).

Please make @cindex entries start with a lower-case letter.
Otherwise, the index could be sorted differently in different locales.

> +Advanced Matrix Extensions (AMX) adds one 64 byte @samp{TILECFG} register and
                               ^^^
Please use @acronym{AMX} there.

> +eight 1024 byte tile registers @samp{TMM0}, @samp{TMM1}, ..., @samp{TMM7}.
                                                            ^^^
This should be @dots{}, not 3 literal period characters.  The former
will look better in print (and even the Info manual).

> +@smallexample
> +	(gdb) print/x $tilecfg_raw
> +	$1 = 0x203020000000000000000000000000000000000000000000000000000001000
> +	10000c00000000000000000000000000000001
> +	(gdb) print $tilecfg
> +	$2 = @{palette = 0x1, start_row = 0x0, tile0.colsb = 0xc,
> +	tile1.colsb = 0x10, tile2.colsb = 0x10, tile3.colsb = 0x0,
> +	tile4.colsb = 0x0, tile5.colsb = 0x0, tile6.colsb = 0x0,
> +	tile7.colsb = 0x0, tile0.rows = 0x2, tile1.rows = 0x3, tile2.rows = 0x2,
> +	tile3.rows = 0x0, tile4.rows = 0x0, tile5.rows = 0x0, tile6.rows = 0x0,
> +	tile7.rows = 0x0@}
> +	(gdb) p $tmm0.m_int8
> +	$3 = @{@{0, 0, 0, 0, 1, 1, 1, 1, 2, 2, 2, 2@},	@{1, 1, 1, 1, 2, 2, 2,
> +	2, 3, 3, 3, 3@}@}
> +@end smallexample

Please avoid such long lines.  TeX cannot break lines in @example, so
we need to do that manually.

The documentation part is OK with the above fixed.

Thanks.

  reply	other threads:[~2022-05-06 12:25 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 12:12 [PATCH 0/4] Add AMX support Felix Willgerodt via Gdb-patches
2022-05-06 12:12 ` [PATCH 1/4] gdb: define int512 and uint512 as built-in types Felix Willgerodt via Gdb-patches
2022-05-06 12:19   ` Eli Zaretskii via Gdb-patches
2022-06-27 18:17   ` Pedro Alves
2022-05-06 12:12 ` [PATCH 2/4] gdb, gdbserver: Add AMX registers Felix Willgerodt via Gdb-patches
2022-05-06 12:25   ` Eli Zaretskii via Gdb-patches [this message]
2022-05-11  8:14     ` Willgerodt, Felix via Gdb-patches
2022-05-11 11:41       ` Eli Zaretskii via Gdb-patches
2022-06-27 18:16         ` Pedro Alves
2022-06-27 18:24           ` Eli Zaretskii via Gdb-patches
2022-06-27 19:15             ` Pedro Alves
2022-06-28 12:09               ` Eli Zaretskii via Gdb-patches
2022-06-28 13:35                 ` Pedro Alves
2022-05-06 16:17   ` John Baldwin
2022-05-09  7:04     ` Willgerodt, Felix via Gdb-patches
2022-05-09 16:31       ` John Baldwin
2022-06-27 18:12   ` Pedro Alves
2022-07-14 10:54     ` Willgerodt, Felix via Gdb-patches
2022-07-15 11:51       ` Willgerodt, Felix via Gdb-patches
2022-08-08  9:15     ` Willgerodt, Felix via Gdb-patches
2022-08-08 17:16       ` John Baldwin
2022-05-06 12:12 ` [PATCH 3/4] gdb, gdbserver: Allocate only a sane amount of buffer when fetching registers Felix Willgerodt via Gdb-patches
2022-05-06 16:08   ` John Baldwin
2022-05-09  7:04     ` Willgerodt, Felix via Gdb-patches
2022-06-27 18:30   ` Pedro Alves
2022-05-06 12:12 ` [PATCH 4/4] gdb: Clear tilecfg.start_row for any PC modification Felix Willgerodt via Gdb-patches
2022-06-27 18:55   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834k2226ht.fsf@gnu.org \
    --to=gdb-patches@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=felix.willgerodt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox