RE: [PATCH 2/4] gdb, gdbserver: Add AMX registers.

["Willgerodt, Felix via Gdb-patches" <gdb-patches@sourceware.org>]

> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Freitag, 6. Mai 2022 14:25
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH 2/4] gdb, gdbserver: Add AMX registers.
> 
> > Date: Fri,  6 May 2022 14:12:24 +0200
> > From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> >
> > +@subsubsection Intel @dfn{Advanced Matrix Extensions} (AMX).
> > +@cindex Advanced Matrix Extensions (AMX).
> 
> Please make @cindex entries start with a lower-case letter.
> Otherwise, the index could be sorted differently in different locales.
> 

I tried it, it just doesn't look right to me if I don't use capital letters.
(Writing "advanced Matrix Extensions" or "advanced matrix extensions".)

There are many index entries starting with capital letters, e.g. AArch64,
ARM or Ada. I see that Intel MPX is added as "Intel Memory Protection
Extensions (MPX)". Features of other vendors/architectures seem to
have similar formatting, like "AArch64 SVE" or "AArch64 Memory
Tagging Extension". Can I use the same formatting for AMX?
E.g. "Intel Advanced Memory Extensions (AMX)".


> > +Advanced Matrix Extensions (AMX) adds one 64 byte @samp{TILECFG}
> register and
>                                ^^^
> Please use @acronym{AMX} there.
> 

I have changed it locally.

> > +eight 1024 byte tile registers @samp{TMM0}, @samp{TMM1}, ...,
> @samp{TMM7}.
>                                                             ^^^
> This should be @dots{}, not 3 literal period characters.  The former
> will look better in print (and even the Info manual).
>

Same.
 
> > +@smallexample
> > +	(gdb) print/x $tilecfg_raw
> > +	$1 =
> 0x203020000000000000000000000000000000000000000000000000000001000
> > +	10000c00000000000000000000000000000001
> > +	(gdb) print $tilecfg
> > +	$2 = @{palette = 0x1, start_row = 0x0, tile0.colsb = 0xc,
> > +	tile1.colsb = 0x10, tile2.colsb = 0x10, tile3.colsb = 0x0,
> > +	tile4.colsb = 0x0, tile5.colsb = 0x0, tile6.colsb = 0x0,
> > +	tile7.colsb = 0x0, tile0.rows = 0x2, tile1.rows = 0x3, tile2.rows = 0x2,
> > +	tile3.rows = 0x0, tile4.rows = 0x0, tile5.rows = 0x0, tile6.rows = 0x0,
> > +	tile7.rows = 0x0@}
> > +	(gdb) p $tmm0.m_int8
> > +	$3 = @{@{0, 0, 0, 0, 1, 1, 1, 1, 2, 2, 2, 2@},	@{1, 1, 1, 1, 2, 2, 2,
> > +	2, 3, 3, 3, 3@}@}
> > +@end smallexample
> 
> Please avoid such long lines.  TeX cannot break lines in @example, so
> we need to do that manually.
> 

Same.

Thanks,
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928