From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NQ6aGsoTdWI1qgQAWB0awg (envelope-from ) for ; Fri, 06 May 2022 08:25:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 5F6F71E058; Fri, 6 May 2022 08:25:46 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=p/M9zsUP; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E0C401E01D for ; Fri, 6 May 2022 08:25:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8125A3953821 for ; Fri, 6 May 2022 12:25:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8125A3953821 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1651839945; bh=tRsC7zXenaSWfBPMDNsraopc4JTBsh2kihBLQuC8Lqs=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=p/M9zsUPZyfAJuTF5BMIJ0B5358BiJs8ST1aEwSendGDHgbo9X1Nwx7MyP31YBzEM y7nFKoOijmfZ31RPOQ1mFdhQCB5fg0/Hy+Zzn2di93NPtTMASguoWQaAaAxxR5cmTI pApniR+EqZrtLc66PMaua2LD0B1JpH1zqLSm7a6U= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 26E5A3952491 for ; Fri, 6 May 2022 12:25:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26E5A3952491 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmx1R-0006aD-Gi; Fri, 06 May 2022 08:25:25 -0400 Received: from [87.69.77.57] (port=2409 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmx1G-0004XT-0v; Fri, 06 May 2022 08:25:23 -0400 Date: Fri, 06 May 2022 15:25:02 +0300 Message-Id: <834k2226ht.fsf@gnu.org> To: Felix Willgerodt In-Reply-To: <20220506121226.137608-3-felix.willgerodt@intel.com> (message from Felix Willgerodt via Gdb-patches on Fri, 6 May 2022 14:12:24 +0200) Subject: Re: [PATCH 2/4] gdb, gdbserver: Add AMX registers. References: <20220506121226.137608-1-felix.willgerodt@intel.com> <20220506121226.137608-3-felix.willgerodt@intel.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Fri, 6 May 2022 14:12:24 +0200 > From: Felix Willgerodt via Gdb-patches > > +@subsubsection Intel @dfn{Advanced Matrix Extensions} (AMX). > +@cindex Advanced Matrix Extensions (AMX). Please make @cindex entries start with a lower-case letter. Otherwise, the index could be sorted differently in different locales. > +Advanced Matrix Extensions (AMX) adds one 64 byte @samp{TILECFG} register and ^^^ Please use @acronym{AMX} there. > +eight 1024 byte tile registers @samp{TMM0}, @samp{TMM1}, ..., @samp{TMM7}. ^^^ This should be @dots{}, not 3 literal period characters. The former will look better in print (and even the Info manual). > +@smallexample > + (gdb) print/x $tilecfg_raw > + $1 = 0x203020000000000000000000000000000000000000000000000000000001000 > + 10000c00000000000000000000000000000001 > + (gdb) print $tilecfg > + $2 = @{palette = 0x1, start_row = 0x0, tile0.colsb = 0xc, > + tile1.colsb = 0x10, tile2.colsb = 0x10, tile3.colsb = 0x0, > + tile4.colsb = 0x0, tile5.colsb = 0x0, tile6.colsb = 0x0, > + tile7.colsb = 0x0, tile0.rows = 0x2, tile1.rows = 0x3, tile2.rows = 0x2, > + tile3.rows = 0x0, tile4.rows = 0x0, tile5.rows = 0x0, tile6.rows = 0x0, > + tile7.rows = 0x0@} > + (gdb) p $tmm0.m_int8 > + $3 = @{@{0, 0, 0, 0, 1, 1, 1, 1, 2, 2, 2, 2@}, @{1, 1, 1, 1, 2, 2, 2, > + 2, 3, 3, 3, 3@}@} > +@end smallexample Please avoid such long lines. TeX cannot break lines in @example, so we need to do that manually. The documentation part is OK with the above fixed. Thanks.