Re: symbolic debug of loadable modules with kgdb light

[Eli Zaretskii <eliz@gnu.org>]

> From: Caz Yokoyama <cazyokoyama@gmail.com>
> Cc: <pedro@codesourcery.com>,
> 	<gdb-patches@sourceware.org>
> Date: Wed, 30 Sep 2009 20:48:37 -0700
> 
> Hello Joel and Eli,
> Here is the patch which integrates your inputs. Even though I carefully look
> through your inputs, there may be missing. Let me know if you find.

Thanks.

> --- gdb/NEWS	15 Sep 2009 03:30:04 -0000	1.331
> +++ gdb/NEWS	1 Oct 2009 03:32:18 -0000
> @@ -3,6 +3,9 @@
>  
>  *** Changes since GDB 6.8
>  
> +* "set/show remotebreak" command is deprecated. Use "set/show remote
> +interrupt-sequence" instead.

I'd prefer this to be in the "New commands" section, even though it is
not strictly speaking a new command.

> +set remote interrupt-sequence [Ctrl-C | BREAK | SysRq-g]
> +show remote interrupt-sequence
> +  Allow the user to select one of ^C, a break or Magic SysRq g as the
> +  sequence to the remote target in order to interrupt the execution.
> +  Ctrl-C is a default.  Some system prefers BREAK which is high level of
> +  serial line for some certain time.  Linux kernel prefers SysRq-g, a.k.a
> +  Magic SysRq. It is BREAK signal and character 'g'.
                ^^
Still one space.

> -  add_setshow_boolean_cmd ("remotebreak", no_class, &remote_break, _("\
> -Set whether to send break if interrupted."), _("\
> -Show whether to send break if interrupted."), _("\
> +  add_setshow_boolean_cmd ("remotebreak", class_obscure, &remote_break, _("\
> +Deprecated. Use \"set remote interrupt-sequence [control-c|break]\" instead."), _("\
> +Deprecated. Use \"show remote interrupt-sequence\" instead."), _("\

You cannot have periods in the first line of the command's doc
string.

> +@item set remote interrupt-sequence
> +@cindex interrupt remote programs
> +@cindex select Ctrl-C, BREAK or SysRq-g
> +Allow the user to specify what sequence @value{GDBN} sends to the remote target
> +when you type @samp{Ctrl-c} to interrupt the program running
> +on the remote target.  Although @samp{Ctrl-C} is usually
> +what remote systems expect (this is the default, here), it is
> +sometimes preferable to send a @code{BREAK}.  When debugging the Linux kernel,
> +a @code{BREAK} followed by @code{g}, which is
> +Magic SysRq g is required in order to interrupt the execution.

Sorry, this still doesn't say what can be given to "set remote
interrupt-sequence" to set the sequence, and does not clearly state
the list of supported alternatives.

> +Specify whether interrupt_sequence is sent
                   ^^^^^^^^^^^^^^^^^^
Why do you use an underscore here?