Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: pedro@codesourcery.com, pmuldoon@redhat.com,
	gdb-patches@sourceware.org, tromey@redhat.com
Subject: Re: [RFC][Python] gdbpy_frame_stop_reason_string bug
Date: Tue, 25 Oct 2011 00:59:00 -0000	[thread overview]
Message-ID: <8339eie2ij.fsf@gnu.org> (raw)
In-Reply-To: <CAPftXULvd+L2aVO-Nh-1SezzUx=Pghfq_cz=PmMM6q3JpAzJHg@mail.gmail.com>

> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Mon, 24 Oct 2011 18:27:01 +0200
> Cc: Pedro Alves <pedro@codesourcery.com>, pmuldoon@redhat.com, gdb-patches@sourceware.org, 
> 	Tom Tromey <tromey@redhat.com>
> 
> ping, you might have missed this thread Eli

Yes, sorry.

> +@item gdb.FRAME_UNWIND_FIRST_ERROR
> +All the conditions after this alias are considered errors;

Hmm...  This table is preceded by this text:

  @defun Frame.unwind_stop_reason ()
  Return an integer representing the reason why it's not possible to find
  more frames toward the outermost frame.  Use
  @code{gdb.frame_stop_reason_string} to convert the value returned by this
  function to a string. The value can be one of:

So "conditions after this alias" seems inappropriate in the list that
follows, because we are not describing conditions or aliases.  Can you
rephrase this to be consistent with the rest of the list.

And why is it important that the value is an alias for another?

> +abnormal stack termination.  Current value is gdb.FRAME_UNWIND_UNAVAILABLE.
                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be in @code{}.

Okay with these changes.

Thanks.


  reply	other threads:[~2011-10-24 17:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12 14:02 Kevin Pouget
2011-10-12 14:33 ` Phil Muldoon
2011-10-12 14:52 ` Pedro Alves
2011-10-12 15:18   ` Kevin Pouget
2011-10-12 15:28     ` Phil Muldoon
2011-10-12 15:59       ` Pedro Alves
2011-10-12 17:07         ` Tom Tromey
2011-10-13 11:25           ` Kevin Pouget
2011-10-13 11:27             ` Kevin Pouget
2011-10-13 15:19               ` Pedro Alves
2011-10-14  8:18                 ` Kevin Pouget
2011-10-14 14:22                   ` Tom Tromey
2011-10-14 14:41                     ` Kevin Pouget
2011-10-14 15:00                       ` Pedro Alves
2011-10-17 10:31                         ` Kevin Pouget
2011-10-19 21:22                           ` Tom Tromey
2011-10-24 16:53                             ` Kevin Pouget
2011-10-25  0:59                               ` Eli Zaretskii [this message]
2011-10-25  8:31                                 ` Kevin Pouget
2011-10-25 12:49                                   ` Eli Zaretskii
2011-10-25 14:27                                     ` Kevin Pouget
2011-10-27 10:02                                       ` Kevin Pouget
2011-10-27 10:16                                         ` Eli Zaretskii
2011-10-27 12:11                                           ` Kevin Pouget
2011-10-12 15:31     ` Pedro Alves
2011-10-12 17:06     ` Tom Tromey
2011-10-12 17:00   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8339eie2ij.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevin.pouget@gmail.com \
    --cc=pedro@codesourcery.com \
    --cc=pmuldoon@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox