From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84644-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9386 invoked by alias); 24 Oct 2011 17:14:07 -0000
Received: (qmail 9372 invoked by uid 22791); 24 Oct 2011 17:14:05 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Oct 2011 17:13:39 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LTK00C00YAEQE00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 24 Oct 2011 19:13:38 +0200 (IST)
Received: from HOME-C4E4A596F7 ([77.124.212.197]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LTK00CZPYILR200@a-mtaout20.012.net.il>; Mon, 24 Oct 2011 19:13:35 +0200 (IST)
Date: Tue, 25 Oct 2011 00:59:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFC][Python] gdbpy_frame_stop_reason_string bug
In-reply-to: <CAPftXULvd+L2aVO-Nh-1SezzUx=Pghfq_cz=PmMM6q3JpAzJHg@mail.gmail.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: pedro@codesourcery.com, pmuldoon@redhat.com, gdb-patches@sourceware.org, tromey@redhat.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <8339eie2ij.fsf@gnu.org>
References: <CAPftXULjbKonB=-YneTVg+jeZiUDUruqtjrTighL8dgXTWoo_g@mail.gmail.com> <m3zkh3ejrc.fsf@fleche.redhat.com> <CAPftXULVgZYuYG7dK2E3=c5F9+gOO3=_jdSCDy2raf9YV9xi3A@mail.gmail.com> <201110141600.20561.pedro@codesourcery.com> <CAPftXUKFN=7FA=bEUoDZ2w4B8h-r=JQFrubpkXLsJ12hGr8EOQ@mail.gmail.com> <m37h40snon.fsf@fleche.redhat.com> <CAPftXULvd+L2aVO-Nh-1SezzUx=Pghfq_cz=PmMM6q3JpAzJHg@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00647.txt.bz2

> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Mon, 24 Oct 2011 18:27:01 +0200
> Cc: Pedro Alves <pedro@codesourcery.com>, pmuldoon@redhat.com, gdb-patches@sourceware.org, 
> 	Tom Tromey <tromey@redhat.com>
> 
> ping, you might have missed this thread Eli

Yes, sorry.

> +@item gdb.FRAME_UNWIND_FIRST_ERROR
> +All the conditions after this alias are considered errors;

Hmm...  This table is preceded by this text:

  @defun Frame.unwind_stop_reason ()
  Return an integer representing the reason why it's not possible to find
  more frames toward the outermost frame.  Use
  @code{gdb.frame_stop_reason_string} to convert the value returned by this
  function to a string. The value can be one of:

So "conditions after this alias" seems inappropriate in the list that
follows, because we are not describing conditions or aliases.  Can you
rephrase this to be consistent with the rest of the list.

And why is it important that the value is an alias for another?

> +abnormal stack termination.  Current value is gdb.FRAME_UNWIND_UNAVAILABLE.
                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This should be in @code{}.

Okay with these changes.

Thanks.