From: Tom Tromey <tromey@redhat.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: Pedro Alves <pedro@codesourcery.com>,
pmuldoon@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFC][Python] gdbpy_frame_stop_reason_string bug
Date: Wed, 19 Oct 2011 21:22:00 -0000 [thread overview]
Message-ID: <m37h40snon.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAPftXUKFN=7FA=bEUoDZ2w4B8h-r=JQFrubpkXLsJ12hGr8EOQ@mail.gmail.com> (Kevin Pouget's message of "Mon, 17 Oct 2011 09:58:32 +0200")
Kevin> I'm not 100% convinced about the last part, but I feel like it would
Kevin> be important to know at read time (instead of run time) what is
Kevin> considered as an error and what isn't. Let me know if you want me to
Kevin> remove/rephrase it.
This needs a doc review.
The code bits are fine with one nit fixed.
Kevin> +#include "../unwind_stop_reasons.def"
I don't think you need ".." here.
Thanks for doing this.
Tom
next prev parent reply other threads:[~2011-10-19 20:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 14:02 Kevin Pouget
2011-10-12 14:33 ` Phil Muldoon
2011-10-12 14:52 ` Pedro Alves
2011-10-12 15:18 ` Kevin Pouget
2011-10-12 15:28 ` Phil Muldoon
2011-10-12 15:59 ` Pedro Alves
2011-10-12 17:07 ` Tom Tromey
2011-10-13 11:25 ` Kevin Pouget
2011-10-13 11:27 ` Kevin Pouget
2011-10-13 15:19 ` Pedro Alves
2011-10-14 8:18 ` Kevin Pouget
2011-10-14 14:22 ` Tom Tromey
2011-10-14 14:41 ` Kevin Pouget
2011-10-14 15:00 ` Pedro Alves
2011-10-17 10:31 ` Kevin Pouget
2011-10-19 21:22 ` Tom Tromey [this message]
2011-10-24 16:53 ` Kevin Pouget
2011-10-25 0:59 ` Eli Zaretskii
2011-10-25 8:31 ` Kevin Pouget
2011-10-25 12:49 ` Eli Zaretskii
2011-10-25 14:27 ` Kevin Pouget
2011-10-27 10:02 ` Kevin Pouget
2011-10-27 10:16 ` Eli Zaretskii
2011-10-27 12:11 ` Kevin Pouget
2011-10-12 15:31 ` Pedro Alves
2011-10-12 17:06 ` Tom Tromey
2011-10-12 17:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37h40snon.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevin.pouget@gmail.com \
--cc=pedro@codesourcery.com \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox