Re: [PATCH 4/6] gdb/record: make record_full_history more c++-like

[Guinevere Larsen <guinevere@redhat.com>]

On 4/18/26 1:03 AM, Thiago Jung Bauermann wrote:
> Guinevere Larsen <guinevere@redhat.com> writes:
>
>> Move some functions to being a method of record_full_history, instead of
>> floating functions.
>> ---
>>   gdb/record-full.c | 25 ++++++++++++-------------
>>   1 file changed, 12 insertions(+), 13 deletions(-)
>>
>> diff --git a/gdb/record-full.c b/gdb/record-full.c
>> index f3737fdbc1f..c9e66fac578 100644
>> --- a/gdb/record-full.c
>> +++ b/gdb/record-full.c
>> @@ -325,6 +325,10 @@ struct record_full_instruction
>>     uint32_t insn_num;
>>     std::optional<gdb_signal> sigval;
>>     std::vector<record_full_entry> effects;
>> +
>> +  /* Execute the full instruction.  As a side effect, set
>> +     record_full_stop_reason.  */
>> +  void exec_insn (regcache *regcache, gdbarch *gdbarch);
> Same comment as in a previous patch: since regcache already has a
> gdbarch, having it as a separate argument is unnecessary.
>
Also fixed

-- 
Cheers,
Guinevere Larsen
It/she