From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ww7nBWkk6WnWODQAWB0awg (envelope-from ) for ; Wed, 22 Apr 2026 15:41:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=C+CqKVQH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 01C901E093; Wed, 22 Apr 2026 15:41:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 529B71E093 for ; Wed, 22 Apr 2026 15:41:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B7ADB44AFF15 for ; Wed, 22 Apr 2026 19:41:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7ADB44AFF15 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=C+CqKVQH Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 26C8040AB68A for ; Wed, 22 Apr 2026 18:51:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26C8040AB68A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26C8040AB68A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776883885; cv=none; b=CvmkSzoyXMQaWTnVOOv+FL7KMNURjQ2sVTYordk8K3TwdRNG9Dbzp4PfaR+z/L+1fGQ7kGXWttNvsascsxemsWAZeo7r47w9gZqclPjOmoaenusTCBnkhFG7tt9fSwsBFaYcLf7mM+GvOLuTo+uUR+uo93eIWmdowgXvfRvR0hQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776883885; c=relaxed/simple; bh=5LbZb+KtoM4Hwn1s6hGvHcbmCAXbZBqYJZ3K4RxPP50=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WiyZXc6gwPSaLm1wsmus+6Z8lCUHbes+jxhT9DMwo3NF3Kw9ELef6+7AwwcuPdgkoA3vCkmP1JqjvZPv5/M0bjq84BjZGCVhrQv4CGKSK5yq3OiTQtI3xjXsO1yhkehnCbD7ULDV2cEdDdq40C5PB23Yjv1rMVXGOfJ90uMeKJs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26C8040AB68A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776883884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lUx2hyMPf3+b/44iU81FCej7A/LmFElx0GnGrNuBQaI=; b=C+CqKVQHpuEzLKiKIog5gA3+KfQqFq6YUy/kT5f3WJIDjGa3UemU6kCynQkn4O5b1eEESv 7ahs0if23E7Fz6e9l0tTuZOgS76YjGm61H1dMXMWscuJz74CVY3UHBy0XoAYtFmiTwIxUN z+9HLbKP3RkQEQ8rdyuB+dDaVt4gGzg= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-1LnA1fZUMV21W1AMQLfNvQ-1; Wed, 22 Apr 2026 14:51:23 -0400 X-MC-Unique: 1LnA1fZUMV21W1AMQLfNvQ-1 X-Mimecast-MFC-AGG-ID: 1LnA1fZUMV21W1AMQLfNvQ_1776883883 Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-56f1fe60919so10608345e0c.2 for ; Wed, 22 Apr 2026 11:51:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776883882; x=1777488682; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lUx2hyMPf3+b/44iU81FCej7A/LmFElx0GnGrNuBQaI=; b=kreDZ3MkBCP86Nq3uYajbUfLRFQHNW+x2zzIhZKx7yx46BwCjTv6MgkcejXf1ceo0F d9p6wI3RI3hh1Gzq6CwgaU4pPyS5sGwM+7oKWLqy4bTTeQR4ilsftNyRzoLqB/2v091k udW8pvn5+w19/Q3NRMFWiPJA3yH7bN7WvETbzG7z130F0iJ+U3pdsG0574H+9016HOkN mN6rpnMlsYhIp4Dok6i6DHyV10VdoNViHFep7wjrgsK/ssiSSECFCybiq+p41Pf5jFDY VqD3y5tym1ZjQ8HIN/rmrzQJ3Zz7UcIumxG4CKNzyxZrI8GobPGTiEvTGtxJtQ03UBro EcnQ== X-Gm-Message-State: AOJu0Yw15L5l4fiC+N+ByF2yMfuHwnN1vrhriZcJsUTw9ab5TBWEoi3s ZiYdn3CdCFAImT/wUu7onUzzaMHgBpVxxvFe+Q2rsdBbbyxj0HOE2/FZkIrZw1qMjRuCULu7Wj+ eRZb6Q36ykH/75LEzLnMIpOaaqSyLYhxA4sZoWynBv/8r/wxPhZqrJNxSo4/Cz7DA+4wzl4Y= X-Gm-Gg: AeBDiesXagMnIYBkM+rI9eym20NMis0M6qFG2xL2BlBIseg0Q1ppbKsBWuhPi414XMK QLFsmzhUbOaFi1XLuZfBze9EtmRl9Pw5OLluS8paxJLnj2d4Pp4xZ2Wmw3HTLwf1BpQpOqrNOQX W3R0hSoe/BMT4K937d/jSc8Edb/6T6igLH5KZZzgG2byzfu0bzXZOCl9DWBxrYfL2fgSxn9F4yT HnWr3uhmqLy80V+V7jI5JkRyFWbX43sc6+FhueHZ9utTGCs9I9Fm6QKNaxJ1Ib3RTy7/9ijPl1q wijr57RCWuCCQ9Zuul1IFYiX75ODHKP+ieGpqSldbgkm5XH2GI8gJ706Hq1vPzbPWgUGRmsMMPa OtonCngkR43ZI3kipiQWNGntvVJ1Ojyx2+ktc+LhAOw== X-Received: by 2002:a05:6122:3109:b0:56d:b337:4709 with SMTP id 71dfb90a1353d-56fa58a88c7mr12633142e0c.6.1776883882678; Wed, 22 Apr 2026 11:51:22 -0700 (PDT) X-Received: by 2002:a05:6122:3109:b0:56d:b337:4709 with SMTP id 71dfb90a1353d-56fa58a88c7mr12633118e0c.6.1776883882234; Wed, 22 Apr 2026 11:51:22 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56fa91ea606sm10266095e0c.5.2026.04.22.11.51.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 11:51:21 -0700 (PDT) Message-ID: <7c6017ae-aff8-4afc-8f64-69a727d4b8ed@redhat.com> Date: Wed, 22 Apr 2026 15:51:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] gdb/record: make record_full_history more c++-like To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org References: <20260415185836.2732968-1-guinevere@redhat.com> <20260415185836.2732968-5-guinevere@redhat.com> <87340sc3uq.fsf@linaro.org> From: Guinevere Larsen In-Reply-To: <87340sc3uq.fsf@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CqTzuQf_wv9t8g-AnMx2fs27WYWVjSPTYetbSjIz9_g_1776883883 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/18/26 1:03 AM, Thiago Jung Bauermann wrote: > Guinevere Larsen writes: > >> Move some functions to being a method of record_full_history, instead of >> floating functions. >> --- >> gdb/record-full.c | 25 ++++++++++++------------- >> 1 file changed, 12 insertions(+), 13 deletions(-) >> >> diff --git a/gdb/record-full.c b/gdb/record-full.c >> index f3737fdbc1f..c9e66fac578 100644 >> --- a/gdb/record-full.c >> +++ b/gdb/record-full.c >> @@ -325,6 +325,10 @@ struct record_full_instruction >> uint32_t insn_num; >> std::optional sigval; >> std::vector effects; >> + >> + /* Execute the full instruction. As a side effect, set >> + record_full_stop_reason. */ >> + void exec_insn (regcache *regcache, gdbarch *gdbarch); > Same comment as in a previous patch: since regcache already has a > gdbarch, having it as a separate argument is unnecessary. > Also fixed -- Cheers, Guinevere Larsen It/she