Re: [PATCH 6/6] gdb/record: Define new version of the record-save section

[Guinevere Larsen <guinevere@redhat.com>]

On 4/16/26 3:00 AM, Eli Zaretskii wrote:
>> From: Guinevere Larsen <guinevere@redhat.com>
>> Cc: Guinevere Larsen <guinevere@redhat.com>
>> Date: Wed, 15 Apr 2026 15:58:36 -0300
>>
>> With the changes to the internal representation of the history, we can
>> no longer support the previous record save format. This commit makes it
>> official, documenting the new format and changing the magic number.
>> ---
>>   gdb/NEWS          |  3 +++
>>   gdb/record-full.c | 35 +++++++++++++++++++++++++++++++----
>>   2 files changed, 34 insertions(+), 4 deletions(-)
> Thanks.
>
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -42,6 +42,9 @@
>>   
>>   * Support for the binary file format dbx has been removed.
>>   
>> +* The format for a saved execution record has been updated, and
>> +  previous formats are no longer supported.
> What's a "saved execution record", and where is it used in GDB?

If a user records the execution of the inferior, using record full, and 
they use the command "record save", they will save the execution log to 
a corefile. That's what I'm referring to.

>    I
> think the NEWS entry should say something about that, or else it's too
> mysterious.
It is a pretty niche feature, hidden in the "obscure" command set, so I 
figured it didn't need to be explained too much
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
>
This is confusing to me. You're supposed to add the review tag when 
you're satisfied with the patch and approving it to go through. So, do 
you think the explanation I gave is enough, or do you want me to explain 
it more on the news file?

-- 
Cheers,
Guinevere Larsen
It/she