Re: [PATCH 6/6] gdb/record: Define new version of the record-save section

Eli Zaretskii
2026-04-16T13:45:54Z

> Date: Thu, 16 Apr 2026 09:41:56 -0300
> Cc: gdb-patches@sourceware.org
> From: Guinevere Larsen <guinevere@redhat.com>
>
> > Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> >
> This is confusing to me. You're supposed to add the review tag when
> you're satisfied with the patch and approving it to go through.

That's not my understanding, since I'm reviewing only part of the
patch. What I usually do is say when I'm satisfied is "this part is
OK" or "the documentation parts are approved".

> So, do you think the explanation I gave is enough, or do you want me
> to explain it more on the news file?

I'd prefer that you at least mention the command(s) which produce and
read these execution records, so that people know what is affected.

Thanks.