Re: [PATCH 6/6] gdb/record: Define new version of the record-save section

Guinevere Larsen
2026-04-16T14:04:00Z

On 4/16/26 10:45 AM, Eli Zaretskii wrote:
>> Date: Thu, 16 Apr 2026 09:41:56 -0300
>> Cc: gdb-patches@sourceware.org
>> From: Guinevere Larsen <guinevere@redhat.com>
>>
>>> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
>>>
>> This is confusing to me. You're supposed to add the review tag when
>> you're satisfied with the patch and approving it to go through.
> That's not my understanding, since I'm reviewing only part of the
> patch. What I usually do is say when I'm satisfied is "this part is
> OK" or "the documentation parts are approved".

The point of the review tag is specifically to remove the ambiguity of
needing to look for ambiguous language like "this part is ok". As the
MAINTAINERS file explains

- Reviewed-By:

Used when a contributor has looked at the code and agrees with
the changes, but either doesn't have the authority or doesn't
feel comfortable approving the patch.

If you would like further changes, you  don't agree with them just yet,
therefore you shouldn't be using the tag. It is here to create a very
obvious "no further discussion is required" demarcation on the list,
which your usage does not follow

>
>> So, do you think the explanation I gave is enough, or do you want me
>> to explain it more on the news file?
> I'd prefer that you at least mention the command(s) which produce and
> read these execution records, so that people know what is affected.
Ok will do.
>
> Thanks.
>

--
Cheers,
Guinevere Larsen
It/she