From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4Yy+ODjZ4GkPBRwAWB0awg (envelope-from ) for ; Thu, 16 Apr 2026 08:42:32 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RVVKem2j; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E4B851E0B1; Thu, 16 Apr 2026 08:42:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B8A5D1E0B1 for ; Thu, 16 Apr 2026 08:42:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id BF8254BA902B for ; Thu, 16 Apr 2026 12:42:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF8254BA902B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RVVKem2j Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 245074BA23CC for ; Thu, 16 Apr 2026 12:42:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 245074BA23CC Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 245074BA23CC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776343325; cv=none; b=xhgV8lFIEJ682u3TLVQRxMzXPQeParRUoV2xo44k4CY/0VuSI1jiCGZI2/dXc64jWVeN4abDl6wNmoH7nfpS4ahSUPHa9L4YjUPZm/pT6n3wPlz6Fjp417q2TuPUDVHdfXoZriWcgobdINkoPYcIvoFN5f5ZCVKv8+7uVdm4M+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776343325; c=relaxed/simple; bh=dtrWnBH2O7krFUllfUGyJy5QFGp+Rz+BfNQmlSyzWwQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=G77UJ05+LWOF3jLsdeocOg3MRNRiEZLUMalixx7sP2buRx8FewNDO6Z7r1EC+AMH2MUw+rdA8/TC9o/iLBXgbAIg0BkkNeUPbVMww8mo1+I6ro7/HgaMmMkScGxIpJlh8o3gSq1q91aZLQlz368lORHQcg1CapFSVyCBdRdeuVE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 245074BA23CC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776343324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5uxXsvgr6T2e5DiyNkmR93I8B+BO1AdvPm9gsntXF+M=; b=RVVKem2jth4fVo/9Vj+B2sNRI7fNQxAk3t9mEH8k3GG7jd0EIpkt7DydnX7qEnyGjSeR6F Kbn2uHPOC/T6g5r+LRV2MZ1KjBMVk5Nvg5eHeQL9uWEDe0eyKQh4MKhM2YY92fwpobyp/U ED2LEoCXVtblYyC/volnjjSjmHGjpQM= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-MfKCdQUmOUaNtQPTvumukA-1; Thu, 16 Apr 2026 08:42:03 -0400 X-MC-Unique: MfKCdQUmOUaNtQPTvumukA-1 X-Mimecast-MFC-AGG-ID: MfKCdQUmOUaNtQPTvumukA_1776343323 Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-56d9f191b6eso14586658e0c.2 for ; Thu, 16 Apr 2026 05:42:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776343322; x=1776948122; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5uxXsvgr6T2e5DiyNkmR93I8B+BO1AdvPm9gsntXF+M=; b=Qj19ilwSt4SEFHPVzyqLkIlvhpSu40p+nA0/Gthvi9FJKkmwIN4x1f2mGEtofzIjfn cXAsPeZdmKJYFFeZERybBp0MzcWHSlFwZY+zoYEth8HWVRIbLsnFnGUEfqG6wAYm2jep +w86E5wqy6f5CmjLlCzFtYxcqL2mVpnsGS+EGGximSkh/pIiMPA8ErOcJmbouNoPWV02 SABoBiGyEkPcD6cgGfvn+Ij3uuNR0Q1BI5AZxbFwQueiW5poAsNYFcedTuhBYiF4O80D i+UfMn2LIozPq1j/ptpxg2gfPfoC/ej6SgwfDwUaCLw5Q5g0qAXA+irL7OfKNsRUtRBG EBnQ== X-Gm-Message-State: AOJu0Yx1mQYX0pAPiiSLXsGM7QQugfQzQ/6GgLIV/x3GzNeC2lLYwOgD ZOaXqlPbDhEUPHSMmYT3WZGczisQUHWwbcBrioCB4hD57Jv0vFhgunXVYQSdqM5guZqUWjMzsfQ oxe35wAE4C2iSJDdjNLzXXiRyHIJsQOUfSPErs3k1Vpv7wCo0Ov5piFmEKRcpy5jF9KAbnjY= X-Gm-Gg: AeBDievLdarhMRy/D6zk1xgh+GVaW39ZsmNJm+no7BnACZWaDTW/0kTMb+NMG/pQ3Gn 2wvFh++nDtEhPKMZgBjw2rW/b1zzGKO/dehJ6LChaxla1wx/Iza99X5zohuMwPff/sGqndyRvhY t5ZwJO9hMifnIOTlg3UbYRIlCK5EmeqcK9YvO1imaqKSXXqtm+lPxz709z5Jq42iPDzCUjFWrGQ bZUgCDj5ARnqZfxutEEHx9FXGtENZUZJAfw1NbtT5CmECaCmtsJ6ButbYpG9dJaUXdZ3prRsyvm hp9nhXyJcEpHpWdQqRlQEAUaK5/2LKU0cceAoLg0scNN6EsOQVt6tikMBKoKePyaORGQwshu4MX h7Ut0jafTPt5YadDjw2fB9pCWgpLGOWw= X-Received: by 2002:a05:6122:9005:b0:56e:8afc:de8c with SMTP id 71dfb90a1353d-56f3bb6a9abmr14365340e0c.3.1776343322579; Thu, 16 Apr 2026 05:42:02 -0700 (PDT) X-Received: by 2002:a05:6122:9005:b0:56e:8afc:de8c with SMTP id 71dfb90a1353d-56f3bb6a9abmr14365332e0c.3.1776343322107; Thu, 16 Apr 2026 05:42:02 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56f89dd3540sm3029728e0c.2.2026.04.16.05.41.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2026 05:42:00 -0700 (PDT) Message-ID: <5de0615d-c637-4025-9bd5-c2cc8063f1e5@redhat.com> Date: Thu, 16 Apr 2026 09:41:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] gdb/record: Define new version of the record-save section To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20260415185836.2732968-1-guinevere@redhat.com> <20260415185836.2732968-7-guinevere@redhat.com> <86pl3zla0b.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <86pl3zla0b.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7PFwB2oE7iqmqApB5sJcpQVU7W0bbDIaJMlpTax60Ao_1776343323 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/16/26 3:00 AM, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: Guinevere Larsen >> Date: Wed, 15 Apr 2026 15:58:36 -0300 >> >> With the changes to the internal representation of the history, we can >> no longer support the previous record save format. This commit makes it >> official, documenting the new format and changing the magic number. >> --- >> gdb/NEWS | 3 +++ >> gdb/record-full.c | 35 +++++++++++++++++++++++++++++++---- >> 2 files changed, 34 insertions(+), 4 deletions(-) > Thanks. > >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -42,6 +42,9 @@ >> >> * Support for the binary file format dbx has been removed. >> >> +* The format for a saved execution record has been updated, and >> + previous formats are no longer supported. > What's a "saved execution record", and where is it used in GDB? If a user records the execution of the inferior, using record full, and they use the command "record save", they will save the execution log to a corefile. That's what I'm referring to. > I > think the NEWS entry should say something about that, or else it's too > mysterious. It is a pretty niche feature, hidden in the "obscure" command set, so I figured it didn't need to be explained too much > > Reviewed-By: Eli Zaretskii > This is confusing to me. You're supposed to add the review tag when you're satisfied with the patch and approving it to go through. So, do you think the explanation I gave is enough, or do you want me to explain it more on the news file? -- Cheers, Guinevere Larsen It/she