Re: [PATCH] gdb: make inferior::terminal a unique ptr

[Simon Marchi <simark@simark.ca>]

On 2020-06-25 1:32 p.m., Pedro Alves wrote:
> On 6/25/20 4:55 PM, Simon Marchi via Gdb-patches wrote:
>> This changes the inferior::terminal field to be a unique pointer, so its
>> deallocation is automatically managed.
>>
>> gdb/ChangeLog:
>>
>> 	* inferior.h (struct inferior) <terminal>: Change type to
>> 	gdb::unique_xmalloc_ptr<char>.
>> 	* inferior.c (inferior::~inferior): Don't free inf->terminal.
>> 	* infcmd.c (set_inferior_io_terminal): Don't free terminal
>> 	field, adjust to unique pointer.
>> 	(get_inferior_io_terminal): Adjust to unique pointer.
>>
> 
> LGTM.
> 
> This reminds me of this patch:
> 
>  https://github.com/palves/gdb/commit/f240d57e3e659d13a01d9dda79120e2ce6bc7e74
> 
> IMO, the code is more readable with that.  WDYT?

I thought about doing something similar... but I limited myself to the original
intent of removing the manual free-ing.  Otherwise, it never ends, there is just
an infinity of such refactors we can do.

But I think your patch looks good.

I'll push mine now.

Simon