Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: make inferior::terminal a unique ptr
Date: Thu, 25 Jun 2020 18:32:49 +0100	[thread overview]
Message-ID: <362a9ac5-7417-8250-ff07-28d31df97f08@palves.net> (raw)
In-Reply-To: <20200625155517.32173-1-simon.marchi@efficios.com>

On 6/25/20 4:55 PM, Simon Marchi via Gdb-patches wrote:
> This changes the inferior::terminal field to be a unique pointer, so its
> deallocation is automatically managed.
> 
> gdb/ChangeLog:
> 
> 	* inferior.h (struct inferior) <terminal>: Change type to
> 	gdb::unique_xmalloc_ptr<char>.
> 	* inferior.c (inferior::~inferior): Don't free inf->terminal.
> 	* infcmd.c (set_inferior_io_terminal): Don't free terminal
> 	field, adjust to unique pointer.
> 	(get_inferior_io_terminal): Adjust to unique pointer.
> 

LGTM.

This reminds me of this patch:

 https://github.com/palves/gdb/commit/f240d57e3e659d13a01d9dda79120e2ce6bc7e74

IMO, the code is more readable with that.  WDYT?

Thanks,
Pedro Alves


  parent reply	other threads:[~2020-06-25 17:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 15:55 Simon Marchi
2020-06-25 17:18 ` Christian Biesinger
2020-06-25 17:28   ` Pedro Alves
2020-06-25 17:59     ` Luis Machado
2020-06-25 18:09       ` Pedro Alves
2020-06-25 18:39         ` Simon Marchi
2020-06-25 21:20         ` Christian Biesinger
2020-06-25 17:32 ` Pedro Alves [this message]
2020-06-25 18:42   ` Simon Marchi
2020-06-25 21:17     ` Pedro Alves
2020-06-25 20:15 ` Tom Tromey
2020-06-25 21:07   ` Simon Marchi
2020-06-25 21:45     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=362a9ac5-7417-8250-ff07-28d31df97f08@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox