Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simark@simark.ca>,
	Simon Marchi <simon.marchi@efficios.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: make inferior::terminal a unique ptr
Date: Thu, 25 Jun 2020 22:17:57 +0100	[thread overview]
Message-ID: <4a26f526-42bd-4019-e12a-e1e7d0d2ff75@palves.net> (raw)
In-Reply-To: <7c472cde-988f-4e13-ccf9-d7144c4e593d@simark.ca>

On 6/25/20 7:42 PM, Simon Marchi wrote:
> On 2020-06-25 1:32 p.m., Pedro Alves wrote:

>> This reminds me of this patch:
>>
>>  https://github.com/palves/gdb/commit/f240d57e3e659d13a01d9dda79120e2ce6bc7e74
>>
>> IMO, the code is more readable with that.  WDYT?
> 
> I thought about doing something similar... but I limited myself to the original
> intent of removing the manual free-ing.  Otherwise, it never ends, there is just
> an infinity of such refactors we can do.

So right you are.  That patch is part of the series to make GDB always put
the inferior on a separate session.  Someday I'll find time to finish it...

> But I think your patch looks good.
> 

I've sent it as a proper patch now:

  https://sourceware.org/pipermail/gdb-patches/2020-June/169896.html

Thanks,
Pedro Alves


  reply	other threads:[~2020-06-25 21:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 15:55 Simon Marchi
2020-06-25 17:18 ` Christian Biesinger
2020-06-25 17:28   ` Pedro Alves
2020-06-25 17:59     ` Luis Machado
2020-06-25 18:09       ` Pedro Alves
2020-06-25 18:39         ` Simon Marchi
2020-06-25 21:20         ` Christian Biesinger
2020-06-25 17:32 ` Pedro Alves
2020-06-25 18:42   ` Simon Marchi
2020-06-25 21:17     ` Pedro Alves [this message]
2020-06-25 20:15 ` Tom Tromey
2020-06-25 21:07   ` Simon Marchi
2020-06-25 21:45     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a26f526-42bd-4019-e12a-e1e7d0d2ff75@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox