Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, heckel_bernhard@web.de
Subject: Re: Copyright status gdb.fortran/vla-stride.exp test-case
Date: Tue, 18 Aug 2020 11:50:29 +0200	[thread overview]
Message-ID: <782fff57-ae6d-5d84-bac4-20a1fe83d747@suse.de> (raw)
In-Reply-To: <20200806133520.GC853475@embecosm.com>

On 8/6/20 3:35 PM, Andrew Burgess wrote:
> * Tom de Vries <tdevries@suse.de> [2020-08-06 12:41:36 +0200]:
> 
>> [ was: Re: [PUSHED] gdb/fortran: Support negative array stride in one
>> limited case ]
>>
>> On 2/25/20 5:35 PM, Andrew Burgess wrote:
>>> This issue was identified on the mailing list by Sergio:
>>>
>>>   https://sourceware.org/ml/gdb-patches/2020-01/msg00360.html
>>>
>>> The test for this issue is a new one written by me as the copyright
>>> status of the original test is currently unknown.
>>
>> I just ran that test-case on master, and it passes, so it could be
>> committed from that point of view.
>>
>> I've tracked down the test-case to commit 4efec01384 "vla: add stride
>> support to fortran arrays." on user branch
>> origin/users/bheckel/fortran-strides :
>> ...
>> commit 4efec01384648183cff07a8d6f050e47074ecfcd
>> Author: Keven Boell <keven.boell@intel.com>
>> Date:   Wed May 28 14:44:11 2014 +0100
>>
>>     vla: add stride support to fortran arrays.
>>
>>     2014-05-28  Bernhard Heckel  <bernhard.heckel@intel.com>
>>                 Sanimir Agovic  <sanimir.agovic@intel.com>
>>                 Keven Boell  <keven.boell@intel.com>
>> ...
>>
>> It's not clear from the patch who contributed to the test-case.
>>
>> Bernard Heckel is listed in MAINTAINERS, the others not, but they are
>> listed in both gdb and gdb/testsuite ChangeLogs.
>>
>> That's as far as I can take it.  Perhaps someone can look up the
>> copyright assignment status.
> 
> I'm confused.  I thought the new test I wrote covered the issues
> Sergio raised.

Right, I'm not questioning that.

> Is there some case that Bernard's test covers that is
> not already covered by the existing Fortran tests?

I don't know.  I assumed that your test covered the problem that was
reported, but not necessarily the whole test in which the problem was found.

>  What's the
> motivation for tracking down the copyright status for this test?

It's part of the fedora patches for gdb, and there is an ongoing effort
to move those to upstream gdb.  And I found that the test-case passed on
trunk, so that looked easy.

Thanks,
- Tom


  reply	other threads:[~2020-08-18  9:50 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 14:56 [review] gdb/fortran: array stride support Andrew Burgess (Code Review)
2019-11-15 22:36 ` Tom Tromey (Code Review)
2019-11-15 23:54 ` Andrew Burgess (Code Review)
2019-11-18 18:58 ` Tom Tromey (Code Review)
2019-11-18 21:47 ` [review v2] " Andrew Burgess (Code Review)
2019-11-18 21:50 ` Andrew Burgess (Code Review)
2019-11-18 21:55 ` [review v3] " Andrew Burgess (Code Review)
2019-11-22 10:10 ` [review v4] " Andrew Burgess (Code Review)
2019-11-22 10:12 ` Andrew Burgess (Code Review)
2019-11-22 13:06 ` Simon Marchi (Code Review)
2019-11-22 17:30 ` [review v5] " Andrew Burgess (Code Review)
2019-11-22 17:31 ` Andrew Burgess (Code Review)
2019-11-22 17:46 ` Simon Marchi (Code Review)
2019-11-28  0:45 ` [review v6] " Andrew Burgess (Code Review)
2019-11-29 23:32 ` [review v7] " Andrew Burgess (Code Review)
2019-11-29 23:35 ` Andrew Burgess (Code Review)
2019-11-30 21:47 ` [review v8] " Andrew Burgess (Code Review)
2019-11-30 22:10 ` [review v9] " Andrew Burgess (Code Review)
2019-11-30 22:11 ` Andrew Burgess (Code Review)
2019-12-01  0:09 ` Simon Marchi (Code Review)
2019-12-01  0:09 ` Simon Marchi (Code Review)
2019-12-01 22:33 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-01 22:33 ` Sourceware to Gerrit sync (Code Review)
2020-01-14  4:11 ` [PATCH] Add gdb.fortran/vla-stride.exp and report a bug (was: Re: [review] gdb/fortran: array stride support) Sergio Durigan Junior
2020-01-19  1:59   ` Andrew Burgess
2020-02-05 16:38     ` [PATCH] Add gdb.fortran/vla-stride.exp and report a bug Sergio Durigan Junior
2020-02-25 16:35       ` [PUSHED] gdb/fortran: Support negative array stride in one limited case Andrew Burgess
2020-08-06 10:41         ` Copyright status gdb.fortran/vla-stride.exp test-case Tom de Vries
2020-08-06 13:35           ` Andrew Burgess
2020-08-18  9:50             ` Tom de Vries [this message]
2020-08-18 10:12               ` Andrew Burgess
2020-12-12  6:33         ` [PUSHED] gdb/fortran: Support negative array stride in one limited case Simon Marchi via Gdb-patches
2020-12-12 22:18           ` Andrew Burgess
2020-12-13  0:51             ` Simon Marchi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=782fff57-ae6d-5d84-bac4-20a1fe83d747@suse.de \
    --to=tdevries@suse.de \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=heckel_bernhard@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox