[review] gdb/fortran: array stride support

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/627
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/gdbtypes.c
| +++ gdb/gdbtypes.c
| @@ -978,17 +1007,18 @@ create_static_range_type (struct type *result_type, struct type *index_type,
|  /* Predicate tests whether BOUNDS are static.  Returns 1 if all bounds values
|     are static, otherwise returns 0.  */
|  
|  static int
|  has_static_range (const struct range_bounds *bounds)
|  {
|    return (bounds->low.kind == PROP_CONST
| -	  && bounds->high.kind == PROP_CONST);
| +	  && bounds->high.kind == PROP_CONST
| +	  && bounds->stride.kind == PROP_CONST);

PS1, Line 1015:

Yes, sorry about this -- I missed the hunk that initializes this
field in create_range_type.

|  }
|  
|  
|  /* Set *LOWP and *HIGHP to the lower and upper bounds of discrete type
|     TYPE.  Return 1 if type is a range type, 0 if it is discrete (and
|     bounds will fit in LONGEST), or -1 otherwise.  */
|  
|  int
|  get_discrete_bounds (struct type *type, LONGEST *lowp, LONGEST *highp)

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9af2bcd1f2d4c56f76f5f3f9f89d8f06bef10d9a
Gerrit-Change-Number: 627
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Mon, 18 Nov 2019 18:58:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrew Burgess <andrew.burgess@embecosm.com>
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment