[review v9] gdb/fortran: array stride support

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/627
......................................................................


Patch Set 9:

(1 comment)

LGTM, I have just noted something about a comment.

| --- gdb/gdbtypes.h
| +++ gdb/gdbtypes.h
| @@ -1960,13 +1977,21 @@ extern struct type *create_static_range_type (struct type *, struct type *,
|  extern struct type *create_array_type_with_stride
|    (struct type *, struct type *, struct type *,
|     struct dynamic_prop *, unsigned int);
|  
|  extern struct type *create_range_type (struct type *, struct type *,
|  				       const struct dynamic_prop *,
|  				       const struct dynamic_prop *,
|  				       LONGEST);
|  
| +/* Like CREATE_RANGE_TYPE but also sets up a stride.  When BYTE_STRIDE_P
| +   is true the value in STRIDE is a byte stride, otherwise STRIDE is a bit
| +   stride.  */

PS9, Line 1988:

I know the surrounding code is like that, but I don't find it very
readable to refer to parameter names when the declaration doesn't
include parameters names.  I'd be much inclined to adding the
parameter names below at the same time.

| +
| +extern struct type * create_range_type_with_stride
| +  (struct type *, struct type *, const struct dynamic_prop *,
| +   const struct dynamic_prop *, LONGEST, const struct dynamic_prop *, bool);
| +
|  extern struct type *create_array_type (struct type *, struct type *,
|  				       struct type *);
|  
|  extern struct type *lookup_array_range_type (struct type *, LONGEST, LONGEST);

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9af2bcd1f2d4c56f76f5f3f9f89d8f06bef10d9a
Gerrit-Change-Number: 627
Gerrit-PatchSet: 9
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Sun, 01 Dec 2019 00:09:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment