Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>,
	gdb-patches@sourceware.org
Cc: nd@arm.com, uweigand@de.ibm.com
Subject: [committed] Fix gdb/remote.c build failure
Date: Wed, 08 Aug 2018 10:33:00 -0000	[thread overview]
Message-ID: <76fc6bee-ead8-5691-d737-e8b25509bd31@arm.com> (raw)
In-Reply-To: <feb8623a-b89e-7519-22de-0d6ede3d5768@arm.com>

Add const qualifier to fix

/S/gdb/common/gdb_locale.h:35:27: error: deprecated conversion from string constant to 'char*' [-Werror=write-strings]
  # define _(String) (String)
                            ^
/S/gdb/remote.c:12844:19: note: in expansion of macro '_'
    char *err_msg = _("Tracepoint packet too large for target.");
                    ^
gdb/ChangeLog:

	* remote.c (remote_target::download_tracepoint): Change char* to
	const char*.
---
  gdb/ChangeLog | 5 +++++
  gdb/remote.c  | 2 +-
  2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6702b445b7..2f5d1ef8b7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-08  Szabolcs Nagy  <szabolcs.nagy@arm.com>
+
+	* remote.c (remote_target::download_tracepoint): Change char* to
+	const char*.
+
  2018-08-07  Simon Marchi  <simon.marchi@polymtl.ca>

  	* target.h (target_options_to_string): Return an std::string.
diff --git a/gdb/remote.c b/gdb/remote.c
index 33f6cd57aa..3b19da75ea 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -12841,7 +12841,7 @@ remote_target::download_tracepoint (struct bp_location *loc)
    struct tracepoint *t = (struct tracepoint *) b;
    struct remote_state *rs = get_remote_state ();
    int ret;
-  char *err_msg = _("Tracepoint packet too large for target.");
+  const char *err_msg = _("Tracepoint packet too large for target.");
    size_t size_left;

    /* We use a buffer other than rs->buf because we'll build strings
-- 
2.14.1


  parent reply	other threads:[~2018-08-08 10:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 21:03 [PATCH v2 0/6] Fix tracepoint register limitations Pedro Franco de Carvalho
2018-07-27 21:03 ` [PATCH v2 4/6] Use remote register numbers in tracepoint mask Pedro Franco de Carvalho
2018-08-02 16:58   ` Ulrich Weigand
2018-08-03 22:09     ` Pedro Franco de Carvalho
2018-08-03 22:10     ` Pedro Franco de Carvalho
2018-08-06 12:42       ` Ulrich Weigand
2018-08-06 20:18         ` Pedro Franco de Carvalho
2018-07-27 21:03 ` [PATCH v2 2/6] Remove trailing '-' from the last QTDP action packet Pedro Franco de Carvalho
2018-08-02 16:44   ` Ulrich Weigand
2018-07-27 21:03 ` [PATCH v2 1/6] Fix indentation in remote_target::download_tracepoint Pedro Franco de Carvalho
2018-08-02 16:43   ` Ulrich Weigand
2018-07-27 21:03 ` [PATCH v2 3/6] Use get_remote_packet_size in download_tracepoint Pedro Franco de Carvalho
2018-08-02 16:47   ` Ulrich Weigand
2018-08-03 21:41     ` Pedro Franco de Carvalho
2018-08-06 12:40       ` Ulrich Weigand
     [not found]       ` <feb8623a-b89e-7519-22de-0d6ede3d5768@arm.com>
2018-08-08 10:33         ` Szabolcs Nagy [this message]
2018-08-08 12:25           ` [committed] Fix gdb/remote.c build failure Ulrich Weigand
2018-08-08 15:55         ` [PATCH v2 3/6] Use get_remote_packet_size in download_tracepoint Pedro Franco de Carvalho
2018-08-03 21:41     ` Pedro Franco de Carvalho
2018-07-27 21:03 ` [PATCH v2 6/6] Allow larger regblock sizes when saving tracefiles Pedro Franco de Carvalho
2018-08-02 17:04   ` Ulrich Weigand
2018-07-27 21:03 ` [PATCH v2 5/6] Variable size for regs mask in collection list Pedro Franco de Carvalho
2018-08-02 17:01   ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76fc6bee-ead8-5691-d737-e8b25509bd31@arm.com \
    --to=szabolcs.nagy@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=pedromfc@linux.ibm.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox