Re: [PATCH v2 3/6] Use get_remote_packet_size in download_tracepoint

Ulrich Weigand
2018-08-06T12:40:50Z

Pedro Franco de Carvalho wrote:

> * remote.c (remote_target::download_tracepoint): Remove BUF_SIZE.
> Replace array buf with gdb::char_vector buf, of size
> get_remote_packet_size (). Replace references to buf and BUF_SIZE
> to buf.data () and buf.size (). Replace strcpy, strcat and
> pack_hex_byte with snprintf. Raise errors if the buffer is too
> small.

This is OK.

Thanks,
Ulrich

--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com