From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60493 invoked by alias); 8 Aug 2018 10:33:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60470 invoked by uid 89); 8 Aug 2018 10:33:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:mail-ve, H*r:15.20.1038.21 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0050.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Aug 2018 10:33:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iP67vuX11C9dxkdAreKQ+ODoNGBv042Nh25lr4mE9gI=; b=HQHcqGqchdXLPYP1+ESRQfwEwD30thvIn02SkpYFpeFHTal/OD6MA92t6RpNa4HVickxhYq0Le84/dk6KHpUYzdHLmSAJzhmra7Xw9ndXHsDojHeEJq2WpmtCncHp/AEjF1EFez5zUsp4YpXtmUuyYCvVyly0XdIF3jASxyphPk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Received: from [10.2.206.57] (217.140.106.54) by AM0PR08MB3282.eurprd08.prod.outlook.com (2603:10a6:208:5e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.21; Wed, 8 Aug 2018 10:33:16 +0000 Cc: nd@arm.com, uweigand@de.ibm.com Subject: [committed] Fix gdb/remote.c build failure From: Szabolcs Nagy To: Pedro Franco de Carvalho , gdb-patches@sourceware.org References: <20180802164652.16707D802AB@oc3748833570.ibm.com> <20180803214124.1033-1-pedromfc@linux.ibm.com> Message-ID: <76fc6bee-ead8-5691-d737-e8b25509bd31@arm.com> Date: Wed, 08 Aug 2018 10:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-Path: szabolcs.nagy@arm.com Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00145.txt.bz2 Add const qualifier to fix /S/gdb/common/gdb_locale.h:35:27: error: deprecated conversion from string constant to 'char*' [-Werror=write-strings] # define _(String) (String) ^ /S/gdb/remote.c:12844:19: note: in expansion of macro '_' char *err_msg = _("Tracepoint packet too large for target."); ^ gdb/ChangeLog: * remote.c (remote_target::download_tracepoint): Change char* to const char*. --- gdb/ChangeLog | 5 +++++ gdb/remote.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6702b445b7..2f5d1ef8b7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-08-08 Szabolcs Nagy + + * remote.c (remote_target::download_tracepoint): Change char* to + const char*. + 2018-08-07 Simon Marchi * target.h (target_options_to_string): Return an std::string. diff --git a/gdb/remote.c b/gdb/remote.c index 33f6cd57aa..3b19da75ea 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -12841,7 +12841,7 @@ remote_target::download_tracepoint (struct bp_location *loc) struct tracepoint *t = (struct tracepoint *) b; struct remote_state *rs = get_remote_state (); int ret; - char *err_msg = _("Tracepoint packet too large for target."); + const char *err_msg = _("Tracepoint packet too large for target."); size_t size_left; /* We use a buffer other than rs->buf because we'll build strings -- 2.14.1