Re: [PATCH v4 0/2] [gdb/exp] Fix ignoring of incorrect namespace prefix

[Tom de Vries <tdevries@suse.de>]

On 4/15/26 12:07 PM, Tom de Vries wrote:
> Hafiz Abid Qadeer reported a problem with namespace handling using a Fortran
> program [1].  I wrote an equivalent program in C++, and reproduced the
> reported problem with both.  While investigating the problem, I ran into
> another problem, for which I filed PR34051.
> 
> This series contains two patches.
> 
> The first patch refactors a complex assignment in
> cp_lookup_symbol_via_imports.
> 
> The second patch fixes PR34051, in that same assignment.
> 
> Tested on aarch64-linux.
> 
> A v1 was submitted here [2].
> 
> Changes in v2 [3]:
> - updated type of directive_match to bool
> 
> Changes in v3 [4]:
> - fixed top-level "return -1" in test-case
> - fixed typo in test-case
> 
> Changes in v4:
> - don't use 1 to set bool
> - added approval tag to first patch
> - replaced "block->function () != nullptr" with
>    "block->function_block () != nullptr" to handle the case that current block
>    is not a function block, but nested in one
> - extended test-case to exercise nested block scenario
> 

I've submitted a v5 that also fixes PR34034.

Thanks,
- Tom

> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34051
> 
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=34034
> [2] v1 https://sourceware.org/pipermail/gdb-patches/2026-April/226370.html
> [3] v2 https://sourceware.org/pipermail/gdb-patches/2026-April/226375.html
> [4] v3 https://sourceware.org/pipermail/gdb-patches/2026-April/226433.html
> 
> Tom de Vries (2):
>    [gdb] Break up complex assignment in cp_lookup_symbol_via_imports
>    [gdb/exp] Fix ignoring of incorrect namespace prefix
> 
>   gdb/cp-namespace.c                 | 28 ++++++++---
>   gdb/testsuite/gdb.cp/nsusing-2.cc  | 62 ++++++++++++++++++++++++
>   gdb/testsuite/gdb.cp/nsusing-2.exp | 75 ++++++++++++++++++++++++++++++
>   3 files changed, 158 insertions(+), 7 deletions(-)
>   create mode 100644 gdb/testsuite/gdb.cp/nsusing-2.cc
>   create mode 100644 gdb/testsuite/gdb.cp/nsusing-2.exp
> 
> 
> base-commit: e860660ab60838b786527823d02b298a3dedcf29